Report the reason a connection was closed. - #157
Merged
Merged
Conversation
Previously, if a websocket connection was closed by the backend, the (websocket-shim) client would be told the connection was closed, but not *why* it was closed. This PR extends the error message to report the underlying error (if any) that triggered the connection closure.
ojarjur
force-pushed
the
ojarjur/report-ws-connection-closure-reasons
branch
from
October 21, 2025 20:16
103ccce to
ac78de6
Compare
gogasca
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if a websocket connection was closed by the backend, the (websocket-shim) client would be told the connection was closed, but not why it was closed.
This PR extends the error message to report the underlying error (if any) that triggered the connection closure.