Implementing secrecy aware operation rebalancing#2917
Open
aymane-eljerari wants to merge 1 commit intogoogle:mainfrom
Open
Implementing secrecy aware operation rebalancing#2917aymane-eljerari wants to merge 1 commit intogoogle:mainfrom
aymane-eljerari wants to merge 1 commit intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
j2kun
approved these changes
May 4, 2026
| // CHECK-DAG: %[[CONST_0:.*]] = arith.constant dense<5.000000e-01> : tensor<1x16xf32> | ||
| // CHECK-DAG: %[[CONST_1:.*]] = arith.constant dense<5.000000e-02> : tensor<1x16xf32> | ||
|
|
||
| // CHECK: %[[RET:.*]] = secret.generic(%arg0: !secret.secret<tensor<1x16xf32>>, %arg1: !secret.secret<tensor<1x16xf32>>, %arg2: tensor<1x16xf32>) |
Collaborator
There was a problem hiding this comment.
Suggested change
| // CHECK: %[[RET:.*]] = secret.generic(%arg0: !secret.secret<tensor<1x16xf32>>, %arg1: !secret.secret<tensor<1x16xf32>>, %arg2: tensor<1x16xf32>) | |
| // CHECK: %[[RET:.*]] = secret.generic(%{{[^:]*}}: !secret.secret<tensor<1x16xf32>>, %{{[^:]*}}: !secret.secret<tensor<1x16xf32>>, %{{[^:]*}}: tensor<1x16xf32>) |
Collaborator
|
When you're ready please squash the commits into one and I will start the automation to merge it |
d11c689 to
0017605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for secrecy aware operation rebalancing using the SecretnessAnalysis solver. Addressing the following issue: (#836)
Before rebuilding the compute graph in
tryBalanceBlock()the code partitions the operands based on their retreived Secretness Value (public values are placed at the beginning of the list maitaining the original DFS order after partitioning).I updated the
balance_sigmoid.mlirsince it was failing due to the re-arragement of operands. The new transformed output maintains sigmoid's computational correctness.I added a new
secrecy_aware_balance.mlirtests. I takes a plaintext function argument and plaintext arith.constants.