Skip to content

Handle broken symlinks in devcontainer set up #5250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dylanjew wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Handle broken symlinks in devcontainer set up #5250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1f9041
Handle broken symlinks in devcontainer set up
dylanjew Apr 21, 2026
1307351
catch bad symlink in assert
dylanjew Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/local/butler/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@

def _compute_revision(timestamp, is_staging=False):
"""Return a source code revision.

This revision contains the timestamp, git-sha, user, config git-sha, and
appengine release (prod or staging). The ordinality of revision is crucial
for updating source code. Later revision *must* be greater than earlier
Expand Down Expand Up @@ -265,7 +265,7 @@
stderr=subprocess.DEVNULL)

if return_code != 0:
raise RuntimeError('Failed to generate requirements from Pipfile.')

Check failure on line 268 in src/local/butler/common.py

View workflow job for this annotation

GitHub Actions / build 

Failed to generate requirements from Pipfile.

with open(requirements_path, 'wb') as f:
f.write(output)
Expand Down Expand Up @@ -351,7 +351,7 @@

def remove_symlink(target):
"""Removes a symlink."""
if not os.path.exists(target):
if not os.path.lexists(target):
return

if os.path.isdir(target) and get_platform() == 'windows':
Expand Down
Loading