Skip to content

Embed links to issues in Triage: messages #5232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StanFromIreland wants to merge 1 commit into
base: master
Choose a base branch
from
+27 −18
Open

Embed links to issues in Triage: messages #5232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/appengine/private/components/testcase-detail/testcase-detail.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,7 +463,7 @@
<span class="help" title="A message related to bug triage and filing.">Triage:</span>
</td>
<td colspan="5" class="value">
[[info.metadata.triage_message]]
<span inner-h-t-m-l="[[info.metadata.triage_message]]"></span>
</td>
</tr>
</template>
Expand Down
28 changes: 15 additions & 13 deletions src/clusterfuzz/_internal/cron/triage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,21 +259,27 @@ def _check_and_update_similar_bug(testcase, issue_tracker):
if not issue:
continue

similar_testcase_id = similar_testcase.key.id()
testcase_url = data_handler.TESTCASE_REPORT_URL.format(
domain=data_handler.get_domain(), testcase_id=similar_testcase_id)
issue_url = issue_tracker.issue_url(issue.id)
testcase_link = f'<a href="{testcase_url}">{similar_testcase_id}</a>'
issue_link = f'<a href="{issue_url}">{issue.id}</a>'

# If the reproducible issue is not verified yet, bug is still valid and
# might be caused by non-availability of latest builds. In that case,
# don't file a new bug yet.
if similar_testcase.open and not similar_testcase.one_time_crasher_flag:
_add_triage_message(
testcase, 'Delaying filing a bug since similar reproducible testcase '
f'({similar_testcase.key.id()} in issue {issue.id}) is not verified '
'yet.')
f'({testcase_link} in issue {issue_link}) is not verified yet.')
return True

# If the issue is still open, no need to file a duplicate bug.
if issue.is_open:
_add_triage_message(
testcase, f'Skipping filing a bug since similar testcase '
f'({similar_testcase.key.id()}) has an open issue ({issue.id}).')
f'({testcase_link}) has an open issue ({issue_link}).')
return True

# If the issue indicates that this crash needs to be ignored, no need to
Expand All @@ -283,12 +289,9 @@ def _check_and_update_similar_bug(testcase, issue_tracker):
if ignore_label in issue.labels:
_add_triage_message(
testcase,
('Skipping filing a bug since similar testcase ({testcase_id}) in '
'issue ({issue_id}) is blacklisted with {ignore_label} label.'
).format(
testcase_id=similar_testcase.key.id(),
issue_id=issue.id,
ignore_label=ignore_label))
f'Skipping filing a bug since similar testcase '
f'({testcase_link}) in issue ({issue_link}) is blacklisted with '
f'{ignore_label} label.')
return True

# If this testcase is not reproducible, and a previous similar
Expand All @@ -299,7 +302,7 @@ def _check_and_update_similar_bug(testcase, issue_tracker):
_add_triage_message(
testcase,
'Skipping filing unreproducible bug since one was already filed '
f'({similar_testcase.key.id()} in issue {issue.id}).')
f'({testcase_link} in issue {issue_link}).')
return True

# If the issue is recently closed, wait certain time period to make sure
Expand All @@ -308,9 +311,8 @@ def _check_and_update_similar_bug(testcase, issue_tracker):
issue.closed_time, hours=data_types.MIN_ELAPSED_TIME_SINCE_FIXED)):
_add_triage_message(
testcase,
('Delaying filing a bug since similar testcase '
'({testcase_id}) in issue ({issue_id}) was just fixed.').format(
testcase_id=similar_testcase.key.id(), issue_id=issue.id))
f'Delaying filing a bug since similar testcase '
f'({testcase_link}) in issue ({issue_link}) was just fixed.')
return True

return False
Expand Down
15 changes: 11 additions & 4 deletions src/clusterfuzz/_internal/tests/appengine/handlers/cron/triage_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,8 +386,11 @@ def test_similar_testcase_with_issue_closed_with_ignore_label(self):

testcase = data_handler.get_testcase_by_id(self.testcase.key.id())
self.assertEqual(
'Skipping filing a bug since similar testcase (2) in issue (1) '
'is blacklisted with ClusterFuzz-Ignore label.',
'Skipping filing a bug since similar testcase '
'(<a href="https://test-clusterfuzz.appspot.com/testcase?key=2">2</a>)'
' in issue '
'(<a href="https://bugs.chromium.org/p/test-project/issues/detail?'
'id=1">1</a>) is blacklisted with ClusterFuzz-Ignore label.',
testcase.get_metadata(triage.TRIAGE_MESSAGE_KEY))

def test_similar_testcase_with_issue_recently_closed(self):
Expand All @@ -412,8 +415,12 @@ def test_similar_testcase_with_issue_recently_closed(self):

testcase = data_handler.get_testcase_by_id(self.testcase.key.id())
self.assertEqual(
'Delaying filing a bug since similar testcase (2) in issue (1) '
'was just fixed.', testcase.get_metadata(triage.TRIAGE_MESSAGE_KEY))
'Delaying filing a bug since similar testcase '
'(<a href="https://test-clusterfuzz.appspot.com/testcase?key=2">2</a>)'
' in issue '
'(<a href="https://bugs.chromium.org/p/test-project/issues/detail?'
'id=1">1</a>) was just fixed.',
testcase.get_metadata(triage.TRIAGE_MESSAGE_KEY))


@test_utils.with_cloud_emulators('datastore')
Expand Down