Skip to content

Set default value of press_enter to True in type_text_at action #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeronGH wants to merge 4 commits into
base: main
Choose a base branch
from
+2 −2
Open

Set default value of press_enter to True in type_text_at action #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7f4ec1
Set default value of press_enter to True in type_text_at action
PeronGH Oct 19, 2025
fe44c2d
Merge branch 'main' into press-enter-default
reachkritz Jun 4, 2026
7dd6199
Merge remote-tracking branch 'upstream/main' into press-enter-default
PeronGH Jun 5, 2026
286fb74
test: update type_text_at assertion for press_enter=True default
PeronGH Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ def handle_action(self, action: types.FunctionCall) -> FunctionResponseT:
elif action.name == "type_text_at":
x = self.denormalize_x(action.args["x"])
y = self.denormalize_y(action.args["y"])
press_enter = action.args.get("press_enter", False)
press_enter = action.args.get("press_enter", True)
clear_before_typing = action.args.get("clear_before_typing", True)
return self._browser_computer.type_text_at(
x=x,
Expand Down
2 changes: 1 addition & 1 deletion test_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def test_handle_action_type_text_at(self):
action = types.FunctionCall(name="type_text_at", args={"x": 100, "y": 200, "text": "hello"})
self.agent.handle_action(action)
self.mock_browser_computer.type_text_at.assert_called_once_with(
x=100, y=200, text="hello", press_enter=False, clear_before_typing=True
x=100, y=200, text="hello", press_enter=True, clear_before_typing=True
)

def test_handle_action_scroll_document(self):
Expand Down