chore: Perf/wheel pipeline and runtime defaults#198
Merged
Conversation
…ift guard The installer requested pywhispercpp 1.4.1 wheels but the workflow built 1.4.0, so every download 404'd and silently fell back to a slow source build (NVIDIA) or PyPI (CPU). Make backend_installer.py the single source of truth: the workflow derives version, CUDA variant, and expected filename by importing it. Build one cuda12 wheel per CUDA major, drop self-hosted CPU wheels (PyPI already ships them), and gate publish on a verify-wheels job that fails on any name/version drift. Point WHEEL_BASE_URL at wheels-v2 and remove dead _parallel_deps_and_wheel.
…rride threads now defaults to min(8, os.cpu_count() or 4) instead of a hardcoded 4. Seed a default word override 'hyper whisper' -> 'hyprwhspr' for the product name; users with their own overrides are never clobbered (config load is a top-level dict replace, so a user's word_overrides fully wins). Update schema (drop pinned numeric threads default) and docs (omit-for-auto note, language auto-detect latency tip) to match.
Continue PR ReviewAutomated review via Continue CLI run through opub. SummaryThe PR is generally sound, but it introduces one likely packaging/install regression for CPU installs and one workflow gap that can let broken release wheels ship despite the new verification job. Findings
Suggested follow-ups
SummaryThe diff is generally solid, but there are a couple of merge-blocking regressions around configuration defaults and wheel-install coverage that should be addressed before release. Findings
Suggested follow-ups
|
f44d4c7 to
fe09812
Compare
- build-cuda: apt-get update before installing libcublas (fresh-runner flakiness) - CPU install: --only-binary=pywhispercpp so a missing PyPI wheel fails clearly instead of silently attempting a source build - CPU install: post-install 'import pywhispercpp' check (using the pip_bin-paired interpreter) so a pip success that didn't install the backend fails cleanly - _detect_venv_python_version: delegate to _get_python_version so a stderr-printing interpreter no longer falls back to the wrong (system) Python and picks a wrong wheel filename - verify-wheels: ldd smoke check fails on any non-CUDA unresolved lib (a real import can't run on GPU-less CI) - tests: _get_wheel_variant / _get_wheel_filename (CUDA 11/12/13/none, py3.10-3.14) and config defaults (threads, word_overrides incl. existing-user preservation) - docs: note the product word override ships by default
fe09812 to
875e087
Compare
Owner
Author
|
Cool, yep, the rest is noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tidy around setup and process, as well as some performance improvements and defaults.