Add first seen date to subscription.#31
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a “first seen” timestamp to subscriber records so the system can track when a subscription entry was originally created, along with a small API addition and minor lint/test cleanups.
Changes:
- Add
Subscriber.FirstSeenand populate it on subscriber creation (CreateSub/CreateSubWithID). - Persist/copy
FirstSeenthrough snapshotting for JSON state operations. - Add
DeleteSubscriber(subID, api)plus tests; minor test refactors and golangci-lint config tweak.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| types.go | Adds Subscriber.FirstSeen with JSON tag to represent record creation time. |
| subscriber.go | Sets FirstSeen on create; introduces DeleteSubscriber API. |
| database.go | Ensures snapshots include FirstSeen so state JSON preserves it. |
| subscriber_test.go | Extends tests to assert FirstSeen behavior and covers DeleteSubscriber. |
| subscription_test.go | Minor lint cleanup (deduplicates string literal via const). |
| .golangci.yml | Disables gomodguard (noted as deprecated) under default: all. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+80
to
+86
| for i, sub := range s.Subscribers { | ||
| if sub.ID == subID && sub.API == api { | ||
| s.Subscribers = append(s.Subscribers[:i], s.Subscribers[i+1:]...) | ||
|
|
||
| return nil | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple features (first seen + delete), and some lint fixes.