Skip to content

Handle 204 No Content response for qBittorrent login #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aractor wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Handle 204 No Content response for qBittorrent login #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions qbit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,13 @@ func (q *Qbit) login(ctx context.Context) error {

body, _ := io.ReadAll(resp.Body)

// qBittorrent 5.2.0+ returns 204 No Content (with an empty body) on a
// successful login, instead of the previous 200 OK with "Ok." in the
// body. Accept 204 as success without requiring the old body match.
if resp.StatusCode == http.StatusNoContent {
return nil
}

if resp.StatusCode != http.StatusOK || !strings.Contains(string(body), "Ok.") {
return fmt.Errorf("%w: %s: %s: %s", ErrLoginFailed, resp.Status, req.URL, string(body))
}
Expand Down