x/oauth2: clarify that ExpiresIn is not automatically populated by the package#747
x/oauth2: clarify that ExpiresIn is not automatically populated by the package#747soh335 wants to merge 1 commit into
Conversation
|
This PR (HEAD: 71e6027) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621195. Important tips:
|
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/621195. |
|
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/621195. |
71e6027 to
117a894
Compare
|
This PR (HEAD: 117a894) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/621195. Important tips:
|
…e package Related golang/go#61417 merges golang#747 (golang#747)
|
This change may get obsoleted by #748 |
|
IMO, I'd merge the doc change in so users have a chance to be aware of this by reading the docs. The respective doc change to remove it can follow the merge of #748. |
Added a note to the
ExpiresInfield documentation to clarify that the oauth2 package does not automatically populate theExpiresInfield, even if the server returns an "expires_in" value. This change helps prevent confusion for developers expecting ExpiresInto be set when interacting with methods likeConfig.Exchange`.