fix: update to use str(commit.id) as hex attribute got removed#532
Merged
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
requested review from
emayuri-godaddy,
rbailey-godaddy and
sushantmimani
Contributor
Author
|
any luck? |
Contributor
|
Thanks for creating a PR. We have been swamped with other things. We will take a look at this soon and update you. |
Adjust expected parameter to match new logic
See if this works around environment build failure for macos-latest 3.8
rbailey-godaddy
approved these changes
Jul 24, 2024
emayuri-godaddy
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help us get this pull request reviewed and merged quickly, please be sure to include the following items:
PR Type
What kind of change does this PR introduce?
Backward Compatibility
Is this change backward compatible with the most recently released version? Does it introduce changes which might change the user experience in any way? Does it alter the API in any way?
Issue Linking
fixes #531
relates to Homebrew/homebrew-core#177628
What's new?