Skip to content

Initial start at webpack 5 and html-bundler-webpack-plugin switch #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chadlwilson wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Initial start at webpack 5 and html-bundler-webpack-plugin switch #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions assets/templates/basic-template.html.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
<html>
<head>
<title><%= htmlWebpackPlugin.options.title %></title>
<title><%= title %></title>
<script defer src="gocd-server-comms.js"></script>
<script defer src="highcharts.src.js"></script>
<script defer src="no-data-to-display.src.js"></script>
<script defer src="xrange.src.js"></script>
<script defer src="@scripts/main.js"></script>
<link href="@scripts/global.scss" rel="stylesheet">
</head>
<body id="<%= htmlWebpackPlugin.options.title %>">
<body id="<%= title %>">
<div id="chart-container"></div>
</body>
</html>
2 changes: 1 addition & 1 deletion config/karma.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

const path = require("path"),
webpack = require("webpack"),
merge = require("webpack-merge");
merge = require("webpack-merge").merge;

const webpackConfig = require('./webpack.config.js')();

Expand Down
56 changes: 24 additions & 32 deletions config/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,7 @@
const webpack = require('webpack');
const path = require('path');
const _ = require('lodash');
const HtmlWebpackPlugin = require('html-webpack-plugin');
const ScriptExtHtmlWebpackPlugin = require('script-ext-html-webpack-plugin');
const LodashModuleReplacementPlugin = require('lodash-webpack-plugin');
const MiniCssExtractPlugin = require('mini-css-extract-plugin');
const HtmlBundlerPlugin = require('html-bundler-webpack-plugin');

const pages = [
{
Expand Down Expand Up @@ -74,40 +71,32 @@ const pages = [
];

/* Every page outputs a corresponding HTML file (page['output_filename']). */
function pluginsToGenerateChartHTMLFiles(env, pages) {
return _.map(pages, function (page) {
return new HtmlWebpackPlugin({
filename: page['output_filename'],
template: path.resolve(__dirname, '..', 'assets', 'templates', page['based_on_template']),
chunks: [page['name'], 'styles'], /* Connects this HTML file to the corresponding entry (and so the JS). */
title: page['name'],
inject: "head",
environment: (env && env['NODE_ENV']) || 'development'
});
});
}

module.exports = (env) => {
return {
/* Every chart has a JS file (chart['entrypoint']) which will be used in the HTML file (see below). */
entry: _.transform(pages, function (accumulator, page) {
accumulator[page['name']] = path.resolve(__dirname, '..', 'assets', 'js', 'pages', page['entrypoint']);
}, {}),

output: {
filename: 'js/[name].js',
path: path.resolve(__dirname, '..', 'build', 'resources', 'webpack')
},

plugins: _.flattenDeep([
new ScriptExtHtmlWebpackPlugin({ defaultAttribute: "defer" }),
pluginsToGenerateChartHTMLFiles(env, pages),
new webpack.IgnorePlugin(/^\.\/locale$/, /moment$/),
new LodashModuleReplacementPlugin({ 'collections': true }),
new MiniCssExtractPlugin({
filename: "[name]-[contenthash].css",
chunkFilename: "[name]-[chunkhash].css"
})
new HtmlBundlerPlugin({
entry: _.map(pages, function (page) {
return {
import: path.resolve(__dirname, '..', 'assets', 'templates', page['based_on_template']),
filename: page['output_filename'],
data: {
title: page['name'],
},
};
}),
js: {
filename: "js/[name].js",
},
css: {
filename: "[name]-[contenthash].css",
chunkFilename: "[name]-[chunkhash].css"
}
}),
new webpack.IgnorePlugin({ resourceRegExp: /^\.\/locale$/, contextRegExp: /moment$/}),
]),

optimization: {
Expand All @@ -125,6 +114,10 @@ module.exports = (env) => {

/* Look at 'assets' directory as well for JS and CSS files when resolving in 'import' statements. */
resolve: {
alias: {
'@scripts': path.join(__dirname, 'src/assets/js'),
'@styles': path.join(__dirname, 'src/assets/css'),
},
extensions: ['.js', '.css', '.scss'],
modules: [path.join(__dirname, '..', 'assets'), 'node_modules']
},
Expand All @@ -143,7 +136,6 @@ module.exports = (env) => {
{
test: /\.s?[ac]ss$/,
use: [
MiniCssExtractPlugin.loader,
'css-loader',
'sass-loader'
]
Expand Down
Loading
Loading