Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/native/compile_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import (

"github.com/gin-gonic/gin"
"github.com/google/go-cmp/cmp"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
yml "go.yaml.in/yaml/v3"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion compiler/registry/github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"reflect"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"golang.org/x/oauth2"
)

Expand Down Expand Up @@ -47,7 +47,7 @@
}

// create the GitHub client
gitClient := github.NewClient(nil)

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / build

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] compiler/registry/github/github.go#L50

assignment mismatch: 1 variable but github.NewClient returns 2 values
Raw output
compiler/registry/github/github.go:50:15: assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / validate

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / validate

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / full-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / full-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / diff-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / test

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / test

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 50 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

assignment mismatch: 1 variable but github.NewClient returns 2 values
// ensure the proper URL is set
gitClient.BaseURL, _ = url.Parse(c.API)

Expand All @@ -73,7 +73,7 @@
tc := oauth2.NewClient(ctx, ts)

// create the GitHub client from the OAuth client
github := github.NewClient(tc)

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / build

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / build

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] compiler/registry/github/github.go#L76

assignment mismatch: 1 variable but github.NewClient returns 2 values
Raw output
compiler/registry/github/github.go:76:12: assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] compiler/registry/github/github.go#L76

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient
Raw output
compiler/registry/github/github.go:76:29: cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / validate

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / validate

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / validate

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / validate

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / full-review

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / full-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / full-review

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / full-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / diff-review

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / diff-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / test

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / test

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / test

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / test

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 76 in compiler/registry/github/github.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

assignment mismatch: 1 variable but github.NewClient returns 2 values

// ensure the proper URL is set
github.BaseURL, _ = url.Parse(c.API)
Expand Down
2 changes: 1 addition & 1 deletion compiler/registry/github/github_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"testing"

"github.com/google/go-cmp/cmp"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"golang.org/x/oauth2"
)

Expand All @@ -19,7 +19,7 @@
s := httptest.NewServer(http.NotFoundHandler())
defer s.Close()

gitClient := github.NewClient(nil)

Check failure on line 22 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] compiler/registry/github/github_test.go#L22

assignment mismatch: 1 variable but github.NewClient returns 2 values
Raw output
compiler/registry/github/github_test.go:22:15: assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 22 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / full-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 22 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / full-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 22 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / diff-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

gitClient.BaseURL, _ = url.Parse(s.URL + "/api/v3/")

Expand Down Expand Up @@ -50,7 +50,7 @@
&oauth2.Token{AccessToken: token},
)
tc := oauth2.NewClient(context.Background(), ts)
gitClient := github.NewClient(tc)

Check failure on line 53 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] compiler/registry/github/github_test.go#L53

assignment mismatch: 1 variable but github.NewClient returns 2 values
Raw output
compiler/registry/github/github_test.go:53:15: assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 53 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] compiler/registry/github/github_test.go#L53

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient (typecheck)
Raw output
compiler/registry/github/github_test.go:53:32: cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient (typecheck)
// SPDX-License-Identifier: Apache-2.0
1 issues:
* typecheck: 1

Check failure on line 53 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / full-review

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient (typecheck)

Check failure on line 53 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / full-review

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 53 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / diff-review

cannot use tc (variable of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient (typecheck)

Check failure on line 53 in compiler/registry/github/github_test.go

View workflow job for this annotation

GitHub Actions / diff-review

assignment mismatch: 1 variable but github.NewClient returns 2 values
gitClient.BaseURL, _ = url.Parse(s.URL + "/api/v3/")

want := &Client{
Expand Down
2 changes: 1 addition & 1 deletion compiler/registry/github/template.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (
"fmt"
"net/http"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"

api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/compiler/registry"
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ require (
github.com/go-playground/assert/v2 v2.2.0
github.com/golang-jwt/jwt/v5 v5.3.1
github.com/google/go-cmp v0.7.0
github.com/google/go-github/v84 v84.0.0
github.com/google/go-github/v90 v90.0.0
github.com/google/uuid v1.6.0
github.com/goware/urlx v0.3.2
github.com/hashicorp/go-cleanhttp v0.5.2
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -141,8 +141,8 @@ github.com/google/go-cmp v0.2.0/go.mod h1:oXzfMopK8JAjlY9xF4vHSVASa0yLyX7SntLO5a
github.com/google/go-cmp v0.6.0/go.mod h1:17dUlkBOakJ0+DkrSSNjCkIjxS6bF9zb3elmeNGIjoY=
github.com/google/go-cmp v0.7.0 h1:wk8382ETsv4JYUZwIsn6YpYiWiBsYLSJiTsyBybVuN8=
github.com/google/go-cmp v0.7.0/go.mod h1:pXiqmnSA92OHEEa9HXL2W4E7lf9JzCmGVUdgjX3N/iU=
github.com/google/go-github/v84 v84.0.0 h1:I/0Xn5IuChMe8TdmI2bbim5nyhaRFJ7DEdzmD2w+yVA=
github.com/google/go-github/v84 v84.0.0/go.mod h1:WwYL1z1ajRdlaPszjVu/47x1L0PXukJBn73xsiYrRRQ=
github.com/google/go-github/v90 v90.0.0 h1:EnX9HvTfqvuJbUSWu1/jLrYH6JJLMz0w0qfQVbTxPzE=
github.com/google/go-github/v90 v90.0.0/go.mod h1:pLzt1FZURZyoTHT5/Z1UQY3b9fYyrbXH6aj7X+qgID4=
github.com/google/go-querystring v1.2.0 h1:yhqkPbu2/OH+V9BfpCVPZkNmUXhb2gBxJArfhIxNtP0=
github.com/google/go-querystring v1.2.0/go.mod h1:8IFJqpSRITyJ8QhQ13bmbeMBDfmeEJZD5A0egEOmkqU=
github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg=
Expand Down
2 changes: 1 addition & 1 deletion scm/github/access.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"context"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/app_permissions.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"fmt"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
)

// see: https://docs.github.com/en/rest/authentication/permissions-required-for-github-apps?apiVersion=2022-11-28
Expand Down
2 changes: 1 addition & 1 deletion scm/github/app_permissions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package github
import (
"testing"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
)

func TestGetInstallationPermission(t *testing.T) {
Expand Down
2 changes: 1 addition & 1 deletion scm/github/app_transport.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"time"

"github.com/golang-jwt/jwt/v5"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace"
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
)
Expand Down Expand Up @@ -318,8 +318,8 @@
func NewTestAppClient(baseURL string) *github.Client {
pk, _ := rsa.GenerateKey(rand.Reader, 2048)

client, err := github.NewClient(

Check failure on line 321 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / build

multiple-value github.NewClient(&http.Client{…}) (value of type (*"github.com/google/go-github/v90/github".Client, error)) in single-value context

Check failure on line 321 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / build

multiple-value github.NewClient(&http.Client{…}) (value of type (*"github.com/google/go-github/v90/github".Client, error)) in single-value context

Check failure on line 321 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / validate

multiple-value github.NewClient(&http.Client{…}) (value of type (*"github.com/google/go-github/v90/github".Client, error)) in single-value context

Check failure on line 321 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / validate

multiple-value github.NewClient(&http.Client{…}) (value of type (*"github.com/google/go-github/v90/github".Client, error)) in single-value context

Check failure on line 321 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / test

multiple-value github.NewClient(&http.Client{…}) (value of type (*"github.com/google/go-github/v90/github".Client, error)) in single-value context

Check failure on line 321 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / test

multiple-value github.NewClient(&http.Client{…}) (value of type (*"github.com/google/go-github/v90/github".Client, error)) in single-value context

Check failure on line 321 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

multiple-value github.NewClient(&http.Client{…}) (value of type (*"github.com/google/go-github/v90/github".Client, error)) in single-value context
&http.Client{

Check failure on line 322 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / build

cannot use &http.Client{…} (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 322 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / build

cannot use &http.Client{…} (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 322 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / validate

cannot use &http.Client{…} (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 322 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / validate

cannot use &http.Client{…} (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 322 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / test

cannot use &http.Client{…} (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 322 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / test

cannot use &http.Client{…} (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 322 in scm/github/app_transport.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

cannot use &http.Client{…} (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient
Transport: &AppsTransport{
BaseURL: baseURL,
Client: &http.Client{Transport: http.DefaultTransport},
Expand Down
2 changes: 1 addition & 1 deletion scm/github/authentication.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"net/url"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"

api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/random"
Expand Down Expand Up @@ -137,7 +137,7 @@
Password: c.config.ClientSecret,
}
// create client to connect to GitHub API
client := github.NewClient(transport.Client())

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / build

cannot use transport.Client() (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / build

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / build

cannot use transport.Client() (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / build

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / validate

cannot use transport.Client() (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / validate

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / validate

cannot use transport.Client() (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / validate

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / test

cannot use transport.Client() (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / test

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / test

cannot use transport.Client() (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / test

assignment mismatch: 1 variable but github.NewClient returns 2 values

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

cannot use transport.Client() (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient

Check failure on line 140 in scm/github/authentication.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

assignment mismatch: 1 variable but github.NewClient returns 2 values
// check if github url was set
if c.config.Address != "" && c.config.Address != "https://github.com" {
// check if address has trailing slash
Expand Down
2 changes: 1 addition & 1 deletion scm/github/changeset.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import (
"context"
"fmt"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"context"
"encoding/json"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down Expand Up @@ -175,17 +175,17 @@

// create the hook object to make the API call
deployment := &github.DeploymentRequest{
Ref: d.Ref,

Check failure on line 178 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / build

cannot use d.Ref (variable of type *string) as string value in struct literal

Check failure on line 178 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / build

cannot use d.Ref (variable of type *string) as string value in struct literal

Check failure on line 178 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / validate

cannot use d.Ref (variable of type *string) as string value in struct literal

Check failure on line 178 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / validate

cannot use d.Ref (variable of type *string) as string value in struct literal

Check failure on line 178 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / test

cannot use d.Ref (variable of type *string) as string value in struct literal

Check failure on line 178 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / test

cannot use d.Ref (variable of type *string) as string value in struct literal

Check failure on line 178 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

cannot use d.Ref (variable of type *string) as string value in struct literal
Task: d.Task,
AutoMerge: new(false),
RequiredContexts: &[]string{},

Check failure on line 181 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / build

cannot use &[]string{} (value of type *[]string) as []string value in struct literal

Check failure on line 181 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / build

cannot use &[]string{} (value of type *[]string) as []string value in struct literal

Check failure on line 181 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / validate

cannot use &[]string{} (value of type *[]string) as []string value in struct literal

Check failure on line 181 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / validate

cannot use &[]string{} (value of type *[]string) as []string value in struct literal

Check failure on line 181 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / test

cannot use &[]string{} (value of type *[]string) as []string value in struct literal

Check failure on line 181 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / test

cannot use &[]string{} (value of type *[]string) as []string value in struct literal

Check failure on line 181 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / Analyze (go)

cannot use &[]string{} (value of type *[]string) as []string value in struct literal
Payload: payload,
Environment: d.Target,
Description: d.Description,
}

// send API call to create the deployment
deploy, _, err := client.Repositories.CreateDeployment(ctx, r.GetOrg(), r.GetName(), deployment)

Check failure on line 188 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / build

cannot use deployment (variable of type *"github.com/google/go-github/v90/github".DeploymentRequest) as "github.com/google/go-github/v90/github".DeploymentRequest value in argument to client.Repositories.CreateDeployment

Check failure on line 188 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / build

cannot use deployment (variable of type *"github.com/google/go-github/v90/github".DeploymentRequest) as "github.com/google/go-github/v90/github".DeploymentRequest value in argument to client.Repositories.CreateDeployment

Check failure on line 188 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / test

cannot use deployment (variable of type *"github.com/google/go-github/v90/github".DeploymentRequest) as "github.com/google/go-github/v90/github".DeploymentRequest value in argument to client.Repositories.CreateDeployment

Check failure on line 188 in scm/github/deployment.go

View workflow job for this annotation

GitHub Actions / test

cannot use deployment (variable of type *"github.com/google/go-github/v90/github".DeploymentRequest) as "github.com/google/go-github/v90/github".DeploymentRequest value in argument to client.Repositories.CreateDeployment
if err != nil {
return err
}
Expand Down
2 changes: 1 addition & 1 deletion scm/github/github.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"os"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"github.com/sirupsen/logrus"
"golang.org/x/oauth2"

Expand Down Expand Up @@ -174,13 +174,13 @@
}

// create a github client based off the existing GitHub App configuration
c.AppClient = github.NewClient(

Check failure on line 177 in scm/github/github.go

View workflow job for this annotation

GitHub Actions / build

assignment mismatch: 1 variable but github.NewClient returns 2 values
&http.Client{

Check failure on line 178 in scm/github/github.go

View workflow job for this annotation

GitHub Actions / build

cannot use &http.Client{…} (value of type *http.Client) as "github.com/google/go-github/v90/github".ClientOptionsFunc value in argument to github.NewClient
Transport: c.newGitHubAppTransport(c.config.AppID, c.config.API, parsedPrivateKey),
})

if c.config.API != defaultAPI {
c.AppClient, err = c.AppClient.WithEnterpriseURLs(c.config.API, c.config.API)

Check failure on line 183 in scm/github/github.go

View workflow job for this annotation

GitHub Actions / build

c.AppClient.WithEnterpriseURLs undefined (type *"github.com/google/go-github/v90/github".Client has no field or method WithEnterpriseURLs)
if err != nil {
return nil, err
}
Expand Down
2 changes: 1 addition & 1 deletion scm/github/github_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"net/url"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"go.opentelemetry.io/contrib/instrumentation/net/http/httptrace/otelhttptrace"
"go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp"
"golang.org/x/oauth2"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/github_client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
"testing"

"github.com/gin-gonic/gin"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"

api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/constants"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/github_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"reflect"
"testing"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"golang.org/x/oauth2"
)

Expand Down
2 changes: 1 addition & 1 deletion scm/github/repo.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import (
"strings"
"time"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/repo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import (

"github.com/gin-gonic/gin"
"github.com/google/go-cmp/cmp"
"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"

api "github.com/go-vela/server/api/types"
"github.com/go-vela/server/constants"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/status.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import (
"strconv"
"strings"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
2 changes: 1 addition & 1 deletion scm/github/webhook.go
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import (
"strings"
"time"

"github.com/google/go-github/v84/github"
"github.com/google/go-github/v90/github"
"github.com/sirupsen/logrus"

api "github.com/go-vela/server/api/types"
Expand Down
Loading