Repository navigation
refactor(content): drop the archived golang/gddo dependency - #75
Merged
Merged
Conversation
LanguageNegotiator used only header.ParseAccept from github.com/golang/gddo, an archived repository pinned at a 2019 pseudo-version. Copy ParseAccept and its helpers into internal/header, keeping the Go Authors copyright and BSD license, together with gddo's ParseAccept test table. The octet table is now built by a function instead of init, and strings.IndexRune(...) >= 0 is written as strings.ContainsRune; the parsing code is unchanged. go.mod no longer requires golang/gddo or go-cmp.
CHANGELOG [Unreleased] gets the CORS preflight fix from #72 with its behaviour note. SECURITY.md points reporters to Report a vulnerability on the Security tab, now that private vulnerability reporting is enabled.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 94.82% 94.85% +0.02%
==========================================
Files 20 21 +1
Lines 947 1010 +63
==========================================
+ Hits 898 958 +60
- Misses 49 52 +3
🚀 New features to boost your workflow:
|
kolkov
added a commit
to zekroTJA/ozzo-routing
that referenced
this pull request
Oct 27, 2026
Brings in the gddo removal (go-ozzo#75) so the branch is up to date with master, as the ruleset requires.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the dependency on
github.com/golang/gddo, an archived repository pinned at a 2019 pseudo-version.content.LanguageNegotiatorused only gddo'sheader.ParseAccept. It and its helpers are copied intointernal/headerwith the Go Authors copyright and BSD license, together with gddo'sParseAccepttest table. The copied code is unchanged apart from building the octet table in a function instead ofinitand writingstrings.IndexRune(...) >= 0asstrings.ContainsRune. Language negotiation behaves exactly as before;go.modno longer requires gddo or go-cmp.Also in this PR: the CHANGELOG entry for #72, and SECURITY.md now points reporters to Report a vulnerability on the Security tab.