Repository navigation
chore: CI on GitHub Actions, Go 1.21 minimum, lint and repository files - #74
Merged
Merged
Conversation
jwt/v5 and io/fs, both planned for v2.5.0, need a newer Go than 1.13; 1.21 is the ecosystem minimum and the oldest Go the CI added next tests. testify v1.4.0 -> v1.12.1, the version ozzo-validation uses.
The linter set and settings of ozzo-validation. Its repository-specific exclusions and gocritic disabled-checks that the linter reports as redundant are dropped; added are exclusions for the exported MIME_* constants (renaming breaks importers) and for the route tree lookup in store.go (hot path, splitting it is a performance change of its own). Fixes without behaviour changes: explicit ignores for ParseMultipartForm (as net/http's FormValue does) and for writing an error body after the status is sent, time.Since, strings.ReplaceAll, reflect.Pointer and PointerTo (Go 1.18), a type switch with assignment, preallocated slices, and blank lines. Read-only file Close and the configured os.Open in file.Content get nolint comments with the reason.
Tests with the race detector on Linux (oldstable, stable), Windows and macOS (stable) and on the minimum Go read from go.mod, a linux/386 build, golangci-lint v2.15.0, gofmt and go mod tidy checks, govulncheck (informational) and Codecov coverage via OIDC. A single gate job named Test is the check the ruleset requires. Dependabot keeps the actions current. README: CI and pkg.go.dev badges, package links to the /v2 module, Go 1.21 as the requirement.
SECURITY.md (private advisories, supported versions, deployment notes), CONTRIBUTING.md, CODEOWNERS, .gitattributes keeping LF endings (the file server tests compare served bytes), .gitignore for build outputs and private directories, and the CHANGELOG entries for these changes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the repository to the same standard as ozzo-validation, ahead of v2.5.0.
io/fschanges planned for v2.5.0, and the oldest Go CI tests. testify v1.4.0 → v1.12.1.go.mod, a linux/386 build, golangci-lint v2.15.0, gofmt andgo mod tidychecks, govulncheck (informational), coverage on Codecov. One gate job namedTestis the check to require in the ruleset..gitattributes(LF endings, the file server tests compare served bytes),.gitignore, README badges and links to the/v2packages, CHANGELOG[Unreleased].govulncheck will report GO-2025-3553 in golang-jwt v3 until the jwt/v5 change lands; that job is not part of the gate.