Repository navigation
chore: upgrade to Go 1.22, update dependencies and CI - #112
Merged
Merged
Conversation
- Bump go directive from 1.13 to 1.22 - Update github.com/go-sql-driver/mysql v1.4.1 -> v1.9.3 - Update github.com/stretchr/testify v1.4.0 -> v1.12.1 - Remove obsolete google.golang.org/appengine indirect dep - Replace deprecated ioutil.ReadFile with os.ReadFile in db_test.go - Update README requirements to Go 1.22 - Bump actions/setup-go@v6 -> @v7 in CI - Add golangci-lint step to CI lint job
kolkov
added
type: enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #112 +/- ##
=======================================
Coverage 86.59% 86.59%
=======================================
Files 16 16
Lines 1514 1514
=======================================
Hits 1311 1311
Misses 154 154
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
- errcheck: check error returns, use _ = for standard cleanup - staticcheck: strings.ReplaceAll, time.Since, type switch assignments - govet: nolint for reflect.Ptr toolchain mismatch, reflect.PointerTo - unused: remove unused struct field - example_test.go: nolint:errcheck for godoc examples
The Exclude().Insert() test intentionally inserts NULL name, which causes scan error when reading into string (not NullString). Original code silently ignored this — restore that behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernize ozzo-dbx: bump Go version, update all dependencies, improve CI pipeline.
go.mod
go 1.13→go 1.22go-sql-driver/mysqlv1.4.1 → v1.9.3 (latest compatible with Go 1.22; v1.10+ requires Go 1.24)stretchr/testifyv1.4.0 → v1.12.1google.golang.org/appengineindirect dependencyCode cleanup
ioutil.ReadFile→os.ReadFile(deprecated since Go 1.16)CI
actions/setup-go@v6→@v7golangci-lint-action@v9(matches ozzo-validation CI)README
Test plan
go build ./...— passesgo vet ./...— passesgofmt -l .— clean