Skip to content

Workaround coverage bug part 2#16906

Merged
techknowlogick merged 2 commits intogo-gitea:mainfrom
zeripath:workaround-coverage-2
Sep 1, 2021
Merged

Workaround coverage bug part 2#16906
techknowlogick merged 2 commits intogo-gitea:mainfrom
zeripath:workaround-coverage-2

Conversation

@zeripath
Copy link
Copy Markdown
Contributor

@zeripath zeripath commented Aug 31, 2021

Just grep away bad lines from coverage files. (Follow on from #16887)

Related #16887
Related #1441

Signed-off-by: Andrew Thornton art27@cantab.net

Just grep away bad lines from coverage files.

Signed-off-by: Andrew Thornton <art27@cantab.net>
@zeripath zeripath added type/testing skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Aug 31, 2021
@zeripath zeripath added this to the 1.16.0 milestone Aug 31, 2021
Signed-off-by: Andrew Thornton <art27@cantab.net>
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #16906 (4cd2ad2) into main (cbf05c3) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16906      +/-   ##
==========================================
- Coverage   45.52%   45.50%   -0.02%     
==========================================
  Files         762      762              
  Lines       86140    86140              
==========================================
- Hits        39213    39200      -13     
- Misses      40616    40629      +13     
  Partials     6311     6311              
Impacted Files Coverage Δ
modules/indexer/stats/db.go 42.85% <0.00%> (-10.72%) ⬇️
modules/charset/charset.go 71.71% <0.00%> (-4.05%) ⬇️
modules/queue/workerpool.go 51.90% <0.00%> (-3.06%) ⬇️
modules/git/repo_language_stats_nogogit.go 47.56% <0.00%> (-2.44%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
modules/git/blame.go 65.71% <0.00%> (-1.43%) ⬇️
modules/git/batch_reader.go 49.09% <0.00%> (-1.22%) ⬇️
models/issue_comment.go 51.76% <0.00%> (+0.29%) ⬆️
services/pull/pull.go 42.19% <0.00%> (+0.40%) ⬆️
modules/process/manager.go 75.30% <0.00%> (+2.46%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbf05c3...4cd2ad2. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 31, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 31, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 1, 2021
@techknowlogick techknowlogick merged commit 83640a5 into go-gitea:main Sep 1, 2021
@zeripath zeripath deleted the workaround-coverage-2 branch September 1, 2021 09:04
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants