Updates for context menu and urls.#1099
Open
ndunsworth wants to merge 2 commits into
Open
Conversation
When bulding the context menu check OSC-8 url events first via vte.hyperlink_check_event(event) then fall back to vte.match_check_event(event) Set the open/copy menu item tooltips to the url string. Preferred over including the url in the menu item name since a url could be massive.
Author
|
I need to fix an incorrect var name is why i pulled it |
Member
|
Ah, do you want me to close it again, or just mark it as a draft for now |
Author
|
That commit i just did should fix it, if not can switch to a draft. I was bad and editing my installed python file while copying it into a clean clone of the repo :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #382 and adds open/copy menu items for OSC-8 url events as the current impl only adds them when vte.match_check_event succeeds.
When bulding the context menu check OSC-8 url events first via vte.hyperlink_check_event(event) then fall back to vte.match_check_event(event)
Set the open/copy menu item tooltips to the url string. Preferred over including the url in the menu item name since a url could be massive.