Fix: change tab title in tab where set_tab_tile is issued#1066
Open
A-725-K wants to merge 1 commit into
Open
Conversation
set_tab_title method now set the title to the tab which UUID matches the one passed to the method, instead of the current tab. Fallback on the current tab, in case the UUID does not match.
Member
|
Thank you so much for this PR, I'm going away for the weekend but I hope to look at it next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1018.
set_tab_titlemethod now set the title to the tab which UUID matches the one passed to the method, instead of the current tab. Fallback on the current tab, in case the UUID does not match.