Skip to content

Fix SaveLastSessionLayout by adding event-driven hooks#1039

Open
henricook wants to merge 1 commit into
gnome-terminator:masterfrom
henricook:fix/save-last-session-layout-reconnect
Open

Fix SaveLastSessionLayout by adding event-driven hooks#1039
henricook wants to merge 1 commit into
gnome-terminator:masterfrom
henricook:fix/save-last-session-layout-reconnect

Conversation

@henricook

Copy link
Copy Markdown

I was looking around for another emulator because I thought my beloved Terminator lacked this, I'd never thought to check the plugins!

When trying this plugin out I found it worked for a single terminal, but didn't pay any attention to new tabs. These changes allow it to do that.

This is my first contribution, please let me know if you'd like any further work or demonstrative testing. I'm using this locally every day at the moment (starting today) so will keep an eye out for bugs.

Comment thread terminatorlib/plugins/save_last_session_layout.py
Comment thread terminatorlib/plugins/save_last_session_layout.py
@mattrose

Copy link
Copy Markdown
Member

Looking at this now. Looks good so far, I'm just going to run a few tests before merging

@henricook

Copy link
Copy Markdown
Author

Thanks Matt! I've been using it locally since I wrote it, every day, and not encountered any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants