Fix ConfigBase.get_item() raising KeyError for any falsey default#1000
Open
alentoghostflame wants to merge 1 commit into
Open
Fix ConfigBase.get_item() raising KeyError for any falsey default#1000alentoghostflame wants to merge 1 commit into
alentoghostflame wants to merge 1 commit into
Conversation
Signed-off-by: Alex Schoenhofen <alexanderschoenhofen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, running
ConfigBase.get_item()with any "falsey" default such as"",0,False, etc. will result in a KeyError being raised. This alters theelifto specifically check if a value other thanNoneis being provided as a default.Not (currently) in this PR, but it might be worth using a custom sentinel value so
Nonecould also be used as a default value?