Make launcher cross-platform#28
Merged
Merged
Conversation
anirudh-bijay-glean
requested review from
eshwar-sundar-glean,
garvit-scio,
mohit-gupta-glean and
swarup-padhi-glean
as code owners
June 24, 2026 21:26
eshwar-sundar-glean
approved these changes
Jun 25, 2026
eshwar-sundar-glean
left a comment
eshwar-sundar-glean
left a comment
Collaborator
There was a problem hiding this comment.
The logic from start.sh to start.mjs looks good to me, check on Claude Code, Codex, Cursor with a clean install on your system and check with QA on windows as well before merge.
anirudh-bijay-glean
left a comment
anirudh-bijay-glean
left a comment
Contributor
Author
There was a problem hiding this comment.
The glob for start.sh in 02-auto-bump-version.sh was missed. Reminder to correct to detect start.mjs before merge.
swarup-padhi-glean
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the launcher script written in Bash (
start.sh) with a cross-platform Node.js script.Why
The Bash script would not run on platforms where Bash is not installed – especially Windows. Moreover, the script itself assumed *nix at places (
/tmp,/dev/null,exec). Node.js scripts are fine since Node is already a prerequisite.Code changes
start.shwith equivalentstart.mjs..mcp.json/.mcp.codex.jsonto launchstart.mjs.start.sh.start.mjs./tmpinindex.tswithtmpdir().