feat(search): serve glean search from the platform API by default - #134
Merged
Conversation
This was referenced Jul 19, 2026
Collaborator
Author
This was referenced Jul 19, 2026
steve-calvert-glean
marked this pull request as ready for review
July 20, 2026 00:17
![glean-it[bot]](https://avatars.githubusercontent.com/u/48140418?s=60&v=4){kind=small}
| } | ||
| resp, err := search.RunSearchSDK(cmd.Context(), opts, sdk) | ||
| if !platform.Legacy() { | ||
| if ignored := platformIgnoredFlags(cmd); len(ignored) > 0 { |
There was a problem hiding this comment.
Issue: The note about legacy-only flags being ignored by platform search is printed before platform.Run executes, so it is emitted whenever GLEAN_LEGACY_APIS is not set, even if platform.Run falls back to the legacy API and those flags are actually honored.
Suggested fix: Move the platformIgnoredFlags(cmd) check to after the platform.Run call and only emit the "flags ignored by platform search" note when viaLegacy is false (i.e., the platform API was used and legacy-only flags truly had no effect).
🔧 Tag @ glean-for-engineering to fix or click here to fix in Glean
💬 Help us improve! Was this comment helpful? React with 👍 or 👎
Brings in the platform API namespaces (s.Search, s.Agents on /api/* routes) and the WithIncludeExperimental SDK option needed for the platform-first migration. Classic s.Client.* surface unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
BuildPlatformSearchRequest maps CLI options onto the narrower platform shape (query, page_size, cursor, datasources via the dedicated field, remaining facet filters as generic filters). RunPlatformSearch calls POST /api/search and honors --timeout via context deadline since the platform request body has no timeoutMillis. Not yet wired into cmd/search. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The flag path calls POST /api/search and falls back to the classic API (with a one-time warning) when the tenant gate is off; GLEAN_LEGACY_APIS=1 forces the classic path. Platform responses are emitted as-is (snake_case, never cleansed); CleanseSearchResponse and --raw now apply only to legacy responses. Explicitly-set flags without a platform equivalent produce a stderr note instead of silently doing nothing. --json payloads are platform-shaped and never auto-fall-back: the body is coupled to the endpoint, so gate-closed produces an actionable error naming GLEAN_LEGACY_APIS=1 (under which the payload is parsed as the classic shape, exactly as before). MockTransport gains per-path Routes so tests can drive the platform 404 → legacy 200 fallback sequence. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
steve-calvert-glean
force-pushed
the
sc/platform-03-search-platform-lib
branch
from
July 27, 2026 17:05
20fe51d to
228208b
Compare
steve-calvert-glean
force-pushed
the
sc/platform-04-search-cmd-migration
branch
from
July 27, 2026 17:05
9e1e0a1 to
13fe792
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
glean search is now platform-first:
Verified with the binary: default dry-run emits the platform snake_case request; GLEAN_LEGACY_APIS=1 emits the classic camelCase request.
Part 4/9.
🤖 Generated with Claude Code