Added warning message about git extension no longer being enabled by default#2197
Open
aaronrsun wants to merge 1 commit intogithub:mainfrom
Open
Added warning message about git extension no longer being enabled by default#2197aaronrsun wants to merge 1 commit intogithub:mainfrom
aaronrsun wants to merge 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a post-init warning to inform users that the bundled git extension will no longer be enabled by default starting in v1.0.0, and introduces tests/spec documentation for that notice.
Changes:
- Track whether the bundled
gitextension was freshly installed duringspecify initand, if so, print a Rich warning panel about the upcoming default-behavior change. - Add CLI tests covering when the deprecation notice should/shouldn’t appear.
- Add a feature spec documenting the motivation and acceptance criteria.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/specify_cli/__init__.py |
Tracks fresh git extension installation and prints an “Upcoming Change” warning panel after init completes. |
tests/extensions/git/test_git_extension.py |
Adds coverage to ensure the warning appears only when the git extension is newly installed (and not with --no-git). |
.specify/features/git-extension-deprecation-notice/spec.md |
Documents the intended behavior and messaging for the deprecation notice. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
aaronrsun
force-pushed
the
fix-issue-2165
branch
from
504cb5d to
1c7350d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #2165
Spec doc: #2196