Skip to content

[Repo Assist] fix: remove redundant log.Printf calls from connection.go #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lpcox merged 2 commits into from
Apr 12, 2026
+1 −6
Merged

[Repo Assist] fix: remove redundant log.Printf calls from connection.go #3640

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
154daef
fix: remove redundant log.Printf calls from connection.go
github-actions[bot] Apr 12, 2026
4462ca9
Update internal/mcp/connection.go
lpcox Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions internal/mcp/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import (
"encoding/json"
"fmt"
"io"
"log"
"net/http"
"os/exec"
"strings"
Expand Down Expand Up @@ -141,11 +140,9 @@ func NewConnection(ctx context.Context, serverID, command string, args []string,
}()

logger.LogInfo("backend", "Starting MCP backend server, command=%s, args=%v", command, sanitize.SanitizeArgs(expandedArgs))
log.Printf("Starting MCP server command: %s %v", command, sanitize.SanitizeArgs(expandedArgs))
transport := &sdk.CommandTransport{Command: cmd}

// Connect to the server (this handles the initialization handshake automatically)
log.Printf("Connecting to MCP server...")
logConn.Print("Initiating MCP server connection and handshake")
session, err := client.Connect(ctx, transport, nil)
if err != nil {
Expand Down Expand Up @@ -175,7 +172,7 @@ func NewConnection(ctx context.Context, serverID, command string, args []string,
isHTTP: false,
}

log.Printf("Started MCP server: %s %v", command, sanitize.SanitizeArgs(args))
logger.LogInfo("backend", "Started MCP server: %s %v", command, sanitize.SanitizeArgs(args))
return conn, nil
}

Expand Down Expand Up @@ -238,7 +235,6 @@ func NewHTTPConnection(ctx context.Context, serverID, url string, headers map[st
conn, err := tryStreamableHTTPTransport(ctx, cancel, serverID, url, headers, headerClient, keepAlive)
if err == nil {
logger.LogInfo("backend", "Successfully connected using streamable HTTP transport, url=%s", url)
log.Printf("Configured HTTP MCP server with streamable transport: %s", url)
return conn, nil
}
logConn.Printf("Streamable HTTP failed: %v", err)
Expand All @@ -261,7 +257,6 @@ func NewHTTPConnection(ctx context.Context, serverID, url string, headers map[st
conn, err = tryPlainJSONTransport(ctx, cancel, serverID, url, headers, headerClient)
if err == nil {
logger.LogInfo("backend", "Successfully connected using plain JSON-RPC transport, url=%s", url)
log.Printf("Configured HTTP MCP server with plain JSON-RPC transport: %s", url)
return conn, nil
}
logConn.Printf("Plain JSON-RPC transport failed: %v", err)
Expand Down
Loading