feat(materialize): add retained CAS materialization handles#751
Conversation
📝 WalkthroughWalkthroughAdds immutable materialization identities, a Git CAS-backed materialization store, runtime service wiring, explicit crypto dependencies, comprehensive tests, and a higher Vitest coverage threshold. ChangesMaterialization storage
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant RuntimeStorageProvider
participant GitCasMaterializationStoreAdapter
participant GitCasFacade
RuntimeStorageProvider->>GitCasMaterializationStoreAdapter: retain coordinate, roots, and state hash
GitCasMaterializationStoreAdapter->>GitCasFacade: write descriptor and root bundle
GitCasFacade-->>GitCasMaterializationStoreAdapter: return cache result and retention witness
RuntimeStorageProvider->>GitCasMaterializationStoreAdapter: findExact coordinate
GitCasMaterializationStoreAdapter->>GitCasFacade: read cache entry and bundle members
GitCasFacade-->>GitCasMaterializationStoreAdapter: return materialization handle
Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
Comment |
Release Preflight
If this PR is from a |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/helpers/InMemoryGitCasFacade.ts`:
- Line 263: Update the PageHandle construction in InMemoryGitCasFacade to derive
hashAlgorithm from the returned oid length, matching the logic used by other
handle constructors. Remove the hard-coded sha1 value so SHA-256 OIDs produce
matching page-handle metadata.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 3ba08ecc-c6f8-4b46-a0fa-39590a0d523a
📒 Files selected for processing (25)
bin/cli/commands/doctor/stateCacheCapability.tsbin/cli/commands/trust.tsbin/cli/commands/verify-audit.tsscripts/migrations/v17.0.0/openCheckpointMigrationStore.tsscripts/v18.0.0/migrations/graph-model/V17RestoredPublicReadLegacyReadingBuilder.tssrc/domain/materialization/MaterializationCoordinate.tssrc/domain/materialization/MaterializationHandle.tssrc/domain/materialization/MaterializationRoots.tssrc/domain/warp/RuntimeHostBoot.tssrc/infrastructure/adapters/GitCasMaterializationStoreAdapter.tssrc/infrastructure/adapters/GitCasRepositoryAdapter.tssrc/ports/MaterializationStorePort.tssrc/ports/RuntimeStorageProviderPort.tstest/conformance/v18FirstUseOpticsHonesty.test.tstest/helpers/InMemoryGitCasFacade.tstest/helpers/MemoryRuntimeStorageAdapter.tstest/integration/infrastructure/adapters/GitCasMaterializationStoreAdapter.integration.test.tstest/integration/infrastructure/adapters/GitCasWarpStateCacheAdapter.retention.integration.test.tstest/unit/domain/WarpCore.blobAutoConstruct.test.tstest/unit/domain/WarpGraph.audit.test.tstest/unit/domain/materialization/MaterializationIdentity.test.tstest/unit/infrastructure/adapters/GitCasMaterializationStoreAdapter.test.tstest/unit/infrastructure/adapters/GitCasRepositoryAdapter.test.tstest/unit/scripts/v16-to-v17-upgrade.test.tsvitest.config.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: coverage-threshold
- GitHub Check: test-node (22)
- GitHub Check: preflight
🧰 Additional context used
📓 Path-based instructions (5)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,js,jsx}: Do not use direct imports fromsrc/infrastructure/**insrc/domain/**orsrc/ports/**; depend on a port instead.
Do not use direct Node built-ins insrc/domain/**orsrc/ports/**; use a port instead.
Files:
test/unit/domain/WarpCore.blobAutoConstruct.test.tssrc/ports/MaterializationStorePort.tstest/conformance/v18FirstUseOpticsHonesty.test.tssrc/domain/warp/RuntimeHostBoot.tstest/unit/domain/WarpGraph.audit.test.tstest/unit/scripts/v16-to-v17-upgrade.test.tsvitest.config.tsbin/cli/commands/trust.tsscripts/migrations/v17.0.0/openCheckpointMigrationStore.tsbin/cli/commands/verify-audit.tsscripts/v18.0.0/migrations/graph-model/V17RestoredPublicReadLegacyReadingBuilder.tsbin/cli/commands/doctor/stateCacheCapability.tstest/integration/infrastructure/adapters/GitCasWarpStateCacheAdapter.retention.integration.test.tstest/helpers/MemoryRuntimeStorageAdapter.tssrc/domain/materialization/MaterializationCoordinate.tstest/unit/domain/materialization/MaterializationIdentity.test.tstest/unit/infrastructure/adapters/GitCasRepositoryAdapter.test.tssrc/ports/RuntimeStorageProviderPort.tstest/integration/infrastructure/adapters/GitCasMaterializationStoreAdapter.integration.test.tssrc/domain/materialization/MaterializationRoots.tssrc/domain/materialization/MaterializationHandle.tssrc/infrastructure/adapters/GitCasMaterializationStoreAdapter.tssrc/infrastructure/adapters/GitCasRepositoryAdapter.tstest/unit/infrastructure/adapters/GitCasMaterializationStoreAdapter.test.tstest/helpers/InMemoryGitCasFacade.ts
src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx,js,jsx}: Do not introduceany,as any,as unknown as,unknown(outside adapters),Record<string, unknown>(outside adapters),*Likeplaceholder types,JSON.parse/JSON.stringify(outside adapters),fetch(outside adapters),process.env(outside adapters),@ts-ignore, orz.any()in core code; use validated boundary models and ports instead.
Use constructor-injected ports for external capabilities; do not rely on ambient dependencies for I/O, clocks, persistence, or entropy.
Do not createutils.ts,helpers.ts,misc.ts, orcommon.ts; name files after the actual concept they model.
Prefer one file per class, type, or object; if a file accumulates peer concepts, split it.
Keep helper corridors, fake shape trust, transitional duplication, and compile-time theater out of the codebase; runtime-honest TypeScript must reflect actual behavior.
No enum usage; prefer runtime-backed domain forms and unions.
Do not use boolean trap parameters; prefer named option objects or separate methods.
Avoid magic strings or numbers when a named constant should exist.
Keep domain bytes asUint8Array;Bufferbelongs in infrastructure adapters.
Files:
src/ports/MaterializationStorePort.tssrc/domain/warp/RuntimeHostBoot.tssrc/domain/materialization/MaterializationCoordinate.tssrc/ports/RuntimeStorageProviderPort.tssrc/domain/materialization/MaterializationRoots.tssrc/domain/materialization/MaterializationHandle.tssrc/infrastructure/adapters/GitCasMaterializationStoreAdapter.tssrc/infrastructure/adapters/GitCasRepositoryAdapter.ts
src/ports/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
In
src/ports/**, do not import Node built-ins orsrc/infrastructure/**; ports must stay abstract and depend only on boundary-safe types.
Files:
src/ports/MaterializationStorePort.tssrc/ports/RuntimeStorageProviderPort.ts
src/domain/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/domain/**/*.{ts,tsx,js,jsx}: Insrc/domain/**, do not useDate.now(),new Date(),Date(),performance.now(),Math.random(),crypto.randomUUID(),crypto.getRandomValues(),setTimeout,setInterval, rawnew Error(...)/new TypeError(...), or direct imports from Node built-ins; time, entropy, and external capabilities must enter through ports or parameters, and domain errors should extendWarpError.
Construct domain objects only in core when doing so establishes validated runtime truth; do not build infrastructure adapters, host APIs, persistence implementations, wall clocks, or entropy sources inside core.
Prefer discriminated unions and explicit result types instead of boolean-flag bags, and model expected failures as return values rather than exceptions.
src/domain/must not import host APIs or Node-specific globals; hexagonal architecture boundaries are mandatory.
Domain code must not use the wall clock directly; time must enter through a port or parameter.
Files:
src/domain/warp/RuntimeHostBoot.tssrc/domain/materialization/MaterializationCoordinate.tssrc/domain/materialization/MaterializationRoots.tssrc/domain/materialization/MaterializationHandle.ts
src/domain/**/!(*.test).{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use explicit domain concepts with validated constructors,
Object.freeze, andinstanceofdispatch; domain objects should be runtime-backed nouns, not ad hoc shape bags.
Files:
src/domain/warp/RuntimeHostBoot.tssrc/domain/materialization/MaterializationCoordinate.tssrc/domain/materialization/MaterializationRoots.tssrc/domain/materialization/MaterializationHandle.ts
🪛 ast-grep (0.44.1)
test/integration/infrastructure/adapters/GitCasMaterializationStoreAdapter.integration.test.ts
[warning] Importing child_process exposes a command-execution surface; ensure any command/argument built from input is validated, and prefer execFile/spawn with an argument array over exec.
Context: import { execFile } from 'node:child_process';
Note: [CWE-78] Improper Neutralization of Special Elements used in an OS Command ('OS Command Injection').
(detect-child-process-typescript)
test/unit/infrastructure/adapters/GitCasMaterializationStoreAdapter.test.ts
[warning] 291-291: Regular expression constructed from variable input detected. This can lead to Regular Expression Denial of Service (ReDoS) attacks if the variable contains malicious patterns. Use libraries like 'recheck' to validate regex safety or use static patterns.
Context: new RegExp(${field} dependency, 'u')
Note: [CWE-1333] Inefficient Regular Expression Complexity
(regexp-from-variable)
🔇 Additional comments (25)
bin/cli/commands/doctor/stateCacheCapability.ts (1)
5-5: LGTM!Also applies to: 22-22
bin/cli/commands/trust.ts (1)
58-65: LGTM!bin/cli/commands/verify-audit.ts (1)
4-4: LGTM!Also applies to: 56-56
scripts/migrations/v17.0.0/openCheckpointMigrationStore.ts (1)
3-3: LGTM!Also applies to: 21-21
test/unit/scripts/v16-to-v17-upgrade.test.ts (1)
75-75: LGTM!vitest.config.ts (1)
33-33: LGTM!scripts/v18.0.0/migrations/graph-model/V17RestoredPublicReadLegacyReadingBuilder.ts (1)
20-20: LGTM!Also applies to: 151-151
src/domain/warp/RuntimeHostBoot.ts (1)
290-290: LGTM!test/integration/infrastructure/adapters/GitCasWarpStateCacheAdapter.retention.integration.test.ts (1)
12-12: LGTM!Also applies to: 99-99
test/unit/domain/WarpCore.blobAutoConstruct.test.ts (1)
5-5: LGTM!Also applies to: 17-17
test/unit/domain/WarpGraph.audit.test.ts (1)
14-14: LGTM!Also applies to: 166-166
src/ports/MaterializationStorePort.ts (1)
1-18: LGTM!src/ports/RuntimeStorageProviderPort.ts (1)
7-11: LGTM!Also applies to: 17-23, 25-36
src/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts (1)
1-78: LGTM!Also applies to: 80-130, 132-225, 227-372
src/infrastructure/adapters/GitCasRepositoryAdapter.ts (1)
19-21: LGTM!Also applies to: 38-54, 91-107, 187-196
test/integration/infrastructure/adapters/GitCasMaterializationStoreAdapter.integration.test.ts (1)
1-173: LGTM!test/helpers/MemoryRuntimeStorageAdapter.ts (1)
11-11: LGTM!Also applies to: 53-102
test/conformance/v18FirstUseOpticsHonesty.test.ts (1)
46-98: LGTM!test/unit/infrastructure/adapters/GitCasRepositoryAdapter.test.ts (1)
11-11: LGTM!Also applies to: 130-131, 144-144, 163-163
src/domain/materialization/MaterializationCoordinate.ts (1)
1-42: LGTM!Also applies to: 44-83
src/domain/materialization/MaterializationRoots.ts (1)
1-61: LGTM!Also applies to: 63-85
src/domain/materialization/MaterializationHandle.ts (1)
1-44: LGTM!Also applies to: 46-70
test/unit/domain/materialization/MaterializationIdentity.test.ts (1)
1-239: LGTM!test/unit/infrastructure/adapters/GitCasMaterializationStoreAdapter.test.ts (1)
1-514: LGTM!test/helpers/InMemoryGitCasFacade.ts (1)
4-108: LGTM!Also applies to: 243-262, 264-335, 444-482
Release Preflight
If this PR is from a |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts (1)
129-143: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winExtract
'evictable'retention policy into a named constant.
CACHE_NAMESPACEandMAX_DESCRIPTOR_BYTESare already named constants at the top of the file, but the retention policy literal'evictable'passed tocache.putis inlined. As per coding guidelines, "Avoid magic strings or numbers when a named constant should exist."♻️ Suggested fix
+const RETENTION_POLICY = 'evictable'; + async `#retainBundle`( bundle: StagedBundle, coordinate: MaterializationCoordinate, ): Promise<StorageRetentionWitness> { const cache = await this.#cas.caches.open({ namespace: CACHE_NAMESPACE }); const cacheKey = await this.#cacheKey(coordinate); - const stored = await cache.put(cacheKey, bundle.handle, { retention: 'evictable' }); + const stored = await cache.put(cacheKey, bundle.handle, { retention: RETENTION_POLICY });🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts` around lines 129 - 143, Introduce a named constant for the `'evictable'` retention policy alongside the existing constants, then update `#retainBundle` to pass that constant in the cache.put options instead of the inline string.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts`:
- Around line 30-40: Make MaterializationRoots.ts the single source of truth by
exporting the canonical MATERIALIZATION_ROOT_NAMES tuple and deriving
MaterializationRootName from its element type. In
GitCasMaterializationStoreAdapter.ts, import and reuse that exported list,
removing the local duplicate declaration while keeping
MATERIALIZATION_MEMBER_COUNT derived from the imported list.
---
Outside diff comments:
In `@src/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts`:
- Around line 129-143: Introduce a named constant for the `'evictable'`
retention policy alongside the existing constants, then update `#retainBundle` to
pass that constant in the cache.put options instead of the inline string.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 22ad1c0d-918b-4aa5-a274-3e771b00933b
📒 Files selected for processing (4)
src/infrastructure/adapters/GitCasMaterializationStoreAdapter.tssrc/infrastructure/adapters/GitCasRepositoryAdapter.tstest/helpers/InMemoryGitCasFacade.tstest/unit/infrastructure/adapters/GitCasMaterializationStoreAdapter.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: test-node (22)
- GitHub Check: coverage-threshold
- GitHub Check: preflight
🧰 Additional context used
📓 Path-based instructions (2)
src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx,js,jsx}: Do not introduceany,as any,as unknown as,unknown(outside adapters),Record<string, unknown>(outside adapters),*Likeplaceholder types,JSON.parse/JSON.stringify(outside adapters),fetch(outside adapters),process.env(outside adapters),@ts-ignore, orz.any()in core code; use validated boundary models and ports instead.
Use constructor-injected ports for external capabilities; do not rely on ambient dependencies for I/O, clocks, persistence, or entropy.
Do not createutils.ts,helpers.ts,misc.ts, orcommon.ts; name files after the actual concept they model.
Prefer one file per class, type, or object; if a file accumulates peer concepts, split it.
Keep helper corridors, fake shape trust, transitional duplication, and compile-time theater out of the codebase; runtime-honest TypeScript must reflect actual behavior.
No enum usage; prefer runtime-backed domain forms and unions.
Do not use boolean trap parameters; prefer named option objects or separate methods.
Avoid magic strings or numbers when a named constant should exist.
Keep domain bytes asUint8Array;Bufferbelongs in infrastructure adapters.
Files:
src/infrastructure/adapters/GitCasRepositoryAdapter.tssrc/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,js,jsx}: Do not use direct imports fromsrc/infrastructure/**insrc/domain/**orsrc/ports/**; depend on a port instead.
Do not use direct Node built-ins insrc/domain/**orsrc/ports/**; use a port instead.
Files:
src/infrastructure/adapters/GitCasRepositoryAdapter.tstest/unit/infrastructure/adapters/GitCasMaterializationStoreAdapter.test.tssrc/infrastructure/adapters/GitCasMaterializationStoreAdapter.tstest/helpers/InMemoryGitCasFacade.ts
🔇 Additional comments (10)
test/helpers/InMemoryGitCasFacade.ts (2)
242-249: Derive the page hash algorithm from the returned OID.
#putPagehard-codessha1, while the same facade derives the algorithm from OID length for assets and bundles. A SHA-256 repository can return a 64-character OID, producing inconsistentPageHandlemetadata and breaking handle round-tripping. Useoid.length === 64 ? 'sha256' : 'sha1'.Also applies to: 251-322
47-106: LGTM!test/unit/infrastructure/adapters/GitCasMaterializationStoreAdapter.test.ts (2)
159-166: LGTM!Also applies to: 528-541
167-170: 🎯 Functional CorrectnessAssert the count-specific error for “too many members.”
Because the added member uses
roots/unknown, this case can also fail through unknown-root validation. Verify that the test asserts the adapter’s exactmaterialization bundle has too many memberserror; otherwise it does not specifically cover the member-count guard.src/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts (4)
70-127: LGTM!
145-213: LGTM! The switch to a singleiterateMemberspass with member-count bounding, duplicate/unknown-member rejection, and lane/coordinate cross-checks in#resolveHitis solid.
286-383: LGTM! Root reconstruction correctly enforces exact membership (no missing/extra/duplicate roots) viarequireRootandparseRootName's strict allowlist.
44-50: 🗄️ Data Integrity & IntegrationConfirm git-cas capability types don't reach the public package surface. Both
GitCasMaterializationFacadeand theGitCasFacadefields derived from it are built directly on@git-stunts/git-cascapability types (BundleCapability,PageCapability,CacheSet), and both are exported from their adapter files — the shared root cause is that no boundary currently prevents these git-cas-shaped types from being re-exported publicly, which would contradict the PR's stated goal of not exposing Git/git-cas through the public surface.
src/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts#L44-L50: confirmGitCasMaterializationFacade(and its git-cas-derived members) is not re-exported from any public barrel/index.src/infrastructure/adapters/GitCasRepositoryAdapter.ts#L48-L49: confirmGitCasFacade.caches/.pages(sourced from the type above) are likewise confined to internal wiring and not part of the public API.src/infrastructure/adapters/GitCasRepositoryAdapter.ts (2)
91-107: LGTM!materializationswiring follows the same request-driven construction pattern as the other stores increateRuntimeStorageServices, and_createMaterializationStorecorrectly threads the request-scopedcodec/cryptoports plustimelineNameas the lane identifier.Also applies to: 187-197
47-47: 🗄️ Data Integrity & IntegrationNo remaining
bundles.getMemberusages
The narrowerbundlestype is fine; nothing in the TypeScript codebase still callsbundles.getMember.> Likely an incorrect or invalid review comment.
Release Preflight
If this PR is from a |
1 similar comment
Release Preflight
If this PR is from a |
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
test/helpers/InMemoryGitCasFacade.ts (1)
289-300: 🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy liftDon't return an anchored cache witness without persisting the root.
#openCachefabricates aRetentionWitnessforrefs/cas/caches/${namespace}, but it only updates#cacheEntries; nothing writes that cache root through#history. Tests can therefore observeanchoredreachability without any real Git reachability, which weakens prune-protection and reachability coverage. Persist the namespace root in history, or make this helper explicitly metadata-only and avoid reportinganchored.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@test/helpers/InMemoryGitCasFacade.ts` around lines 289 - 300, Update `#openCache` so the cache root for refs/cas/caches/${namespace} is persisted through `#history` before returning the RetentionWitness with anchored reachability. Ensure the persisted history entry uses the same namespace, generation, and root path represented by the witness; otherwise make the helper metadata-only and change the witness reachability from anchored.Source: MCP tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/domain/materialization/MaterializationRoots.ts`:
- Around line 4-15: Update the entries() implementation in MaterializationRoots
to derive its root names from MATERIALIZATION_ROOT_NAMES instead of hardcoding
them. Centralize the name-to-handle mapping and iterate the canonical tuple so
member counts, parsing, and bundle writing remain synchronized when roots are
added.
---
Outside diff comments:
In `@test/helpers/InMemoryGitCasFacade.ts`:
- Around line 289-300: Update `#openCache` so the cache root for
refs/cas/caches/${namespace} is persisted through `#history` before returning the
RetentionWitness with anchored reachability. Ensure the persisted history entry
uses the same namespace, generation, and root path represented by the witness;
otherwise make the helper metadata-only and change the witness reachability from
anchored.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: c7e37dc1-c5bd-4dca-bf90-2c78551d8f5b
📒 Files selected for processing (5)
src/domain/materialization/MaterializationRoots.tssrc/infrastructure/adapters/GitCasMaterializationStoreAdapter.tstest/helpers/InMemoryGitCasFacade.tstest/unit/domain/materialization/MaterializationIdentity.test.tstest/unit/helpers/InMemoryGitCasFacade.test.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (4)
- GitHub Check: coverage-threshold
- GitHub Check: test-node (22)
- GitHub Check: test-bun
- GitHub Check: preflight
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,js,jsx}: Do not use direct imports fromsrc/infrastructure/**insrc/domain/**orsrc/ports/**; depend on a port instead.
Do not use direct Node built-ins insrc/domain/**orsrc/ports/**; use a port instead.
Files:
test/unit/helpers/InMemoryGitCasFacade.test.tstest/unit/domain/materialization/MaterializationIdentity.test.tssrc/domain/materialization/MaterializationRoots.tstest/helpers/InMemoryGitCasFacade.tssrc/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts
src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx,js,jsx}: Do not introduceany,as any,as unknown as,unknown(outside adapters),Record<string, unknown>(outside adapters),*Likeplaceholder types,JSON.parse/JSON.stringify(outside adapters),fetch(outside adapters),process.env(outside adapters),@ts-ignore, orz.any()in core code; use validated boundary models and ports instead.
Use constructor-injected ports for external capabilities; do not rely on ambient dependencies for I/O, clocks, persistence, or entropy.
Do not createutils.ts,helpers.ts,misc.ts, orcommon.ts; name files after the actual concept they model.
Prefer one file per class, type, or object; if a file accumulates peer concepts, split it.
Keep helper corridors, fake shape trust, transitional duplication, and compile-time theater out of the codebase; runtime-honest TypeScript must reflect actual behavior.
No enum usage; prefer runtime-backed domain forms and unions.
Do not use boolean trap parameters; prefer named option objects or separate methods.
Avoid magic strings or numbers when a named constant should exist.
Keep domain bytes asUint8Array;Bufferbelongs in infrastructure adapters.
Files:
src/domain/materialization/MaterializationRoots.tssrc/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts
src/domain/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/domain/**/*.{ts,tsx,js,jsx}: Insrc/domain/**, do not useDate.now(),new Date(),Date(),performance.now(),Math.random(),crypto.randomUUID(),crypto.getRandomValues(),setTimeout,setInterval, rawnew Error(...)/new TypeError(...), or direct imports from Node built-ins; time, entropy, and external capabilities must enter through ports or parameters, and domain errors should extendWarpError.
Construct domain objects only in core when doing so establishes validated runtime truth; do not build infrastructure adapters, host APIs, persistence implementations, wall clocks, or entropy sources inside core.
Prefer discriminated unions and explicit result types instead of boolean-flag bags, and model expected failures as return values rather than exceptions.
src/domain/must not import host APIs or Node-specific globals; hexagonal architecture boundaries are mandatory.
Domain code must not use the wall clock directly; time must enter through a port or parameter.
Files:
src/domain/materialization/MaterializationRoots.ts
src/domain/**/!(*.test).{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use explicit domain concepts with validated constructors,
Object.freeze, andinstanceofdispatch; domain objects should be runtime-backed nouns, not ad hoc shape bags.
Files:
src/domain/materialization/MaterializationRoots.ts
🔇 Additional comments (11)
src/domain/materialization/MaterializationRoots.ts (2)
15-26: LGTM!Also applies to: 28-50, 66-71, 78-83, 85-89, 91-93
73-76: 📐 Maintainability & Code QualityNo change needed:
MATERIALIZATION_ROOT_NAMESis already readonly.defineRootNamesyields areadonly [...]tuple at the call site, so.push(...)is already a type error;Readonly<Names>is unnecessary.> Likely an incorrect or invalid review comment.src/infrastructure/adapters/GitCasMaterializationStoreAdapter.ts (1)
1-33: LGTM!Also applies to: 34-60, 61-119, 120-135, 137-174, 176-187, 189-205, 208-233, 234-290, 291-355, 356-375, 376-438
test/unit/domain/materialization/MaterializationIdentity.test.ts (1)
4-7: LGTM!Also applies to: 110-111
test/unit/helpers/InMemoryGitCasFacade.test.ts (1)
1-22: LGTM!test/helpers/InMemoryGitCasFacade.ts (6)
4-19: LGTM!
50-63: LGTM!Also applies to: 80-86
96-107: LGTM!
242-260: LGTM!Also applies to: 262-276
434-450: LGTM!
283-323: 🗄️ Data Integrity & IntegrationModel the cache fake’s full contract The helper drops
expiresAt,expectedHandle, andlogicalBytes, so tests won’t catch TTL, CAS, or size-accounting bugs.
Release Preflight
If this PR is from a |
1 participant
Summary
Scope boundary
Refs #738
Refs #734
This foundation does not close #738.
RuntimeHoststill retains a completeWarpState; streaming reducer output, bounded handle-backed reads, constrained-memory proof, and normal-path resident-state removal remain follow-up slices.Review
Validation
npm run lintnpm run lint:sludgenpm run typechecknpm run typecheck:policynpm run typecheck:surfacegit prune -n --expire=now