Delete dead WARP caches and homemade CAS paths#746
Conversation
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 36 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe PR removes WARP-owned seek, adjacency, CAS, index, memoization, health-check, and in-memory production storage components. CLI and runtime contracts, storage exports, documentation, test helpers, and boundary validation are updated accordingly. ChangesWARP ownership boundary cleanup
Estimated code review effort: 4 (Complex) | ~60 minutes Possibly related issues
Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Comment |
Release Preflight
If this PR is from a |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/unit/scripts/storage-ownership-boundary.test.ts`:
- Around line 66-76: Update the identifier check in the AST traversal to match
against both REMOVED_PRODUCTION_IDENTIFIERS and REMOVED_PRODUCTION_SYMBOLS,
ensuring removed names are detected in variables, functions, and export aliases.
Then remove the now-redundant declaration-specific branch that separately checks
class, interface, and type alias names.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: b7e03765-3243-4e20-8506-7e991426e3cb
📒 Files selected for processing (139)
ARCHITECTURE.mdbin/cli/commands/check.tsbin/cli/commands/doctor/checks.tsbin/cli/commands/seek.tsbin/cli/schemas.tsbin/cli/shared.tsbin/cli/types.tsbin/warp-graph.tsdocs/TECHNICAL_TEARDOWN.mddocs/migrations/v19/README.mddocs/topics/api/README.mddocs/topics/reference.mddocs/topics/unmaterialized-intents.mdeslint.config.tsscripts/check-source-backed-reference.tsscripts/smoke-packed-artifact.shscripts/source-version-name-policy.tssrc/application/WarpStorageRegistry.tssrc/domain/RuntimeHost.tssrc/domain/WarpCore.tssrc/domain/WarpGraph.tssrc/domain/runtimeHelpers.tssrc/domain/services/HealthCheckService.tssrc/domain/services/PatchBuilder.tssrc/domain/services/controllers/ForkController.tssrc/domain/services/controllers/IntentController.tssrc/domain/services/controllers/detachedOpen.tssrc/domain/services/index/IndexRebuildService.tssrc/domain/services/index/IndexStalenessChecker.tssrc/domain/services/index/StreamingBitmapIndexBuilder.tssrc/domain/services/materialize/CasFirstMemoizationEngine.tssrc/domain/services/optic/StreamingCheckpointBasisBuilder.tssrc/domain/utils/CachedValue.tssrc/domain/utils/RefLayout.tssrc/domain/utils/seekCacheKey.tssrc/domain/warp/RuntimeHostBoot.tssrc/domain/warp/RuntimeHostProduct.tssrc/domain/warp/WarpCoreRuntimeProduct.tssrc/infrastructure/adapters/CasIndexStorageAdapter.tssrc/infrastructure/adapters/CasSeekCacheAdapter.tssrc/infrastructure/adapters/GitCasRepositoryAdapter.tssrc/infrastructure/adapters/sha1sync.tssrc/ports/SeekCachePort.tssrc/ports/StreamingIndexStoragePort.tsstorage.tstest/benchmark/detachedReadBenchmark.fixture.tstest/conformance/fixtures/V17CheckpointTailOpticGraphFixture.tstest/conformance/post-v17/graphQueryBoundedProvider.blocked.test.tstest/conformance/v18BoundedMemoryLargeGraphGate.test.tstest/conformance/v18CoordinateOpticPublicPath.test.tstest/conformance/v18FirstUseOpticsHonesty.test.tstest/helpers/BoundedReadBasis.tstest/helpers/InMemoryBlobStorageAdapter.tstest/helpers/InMemoryGraphAdapter.tstest/helpers/MemoryRuntimeHost.tstest/helpers/MemoryRuntimeStorageAdapter.tstest/helpers/MemoryStorage.tstest/helpers/MockIndexStorage.tstest/helpers/MockStreamingIndexStorage.tstest/helpers/WarpGraphTestRepositories.tstest/helpers/inMemoryHashing.tstest/helpers/mockHost.tstest/type-check/v19-consumer.tstest/type-check/v19-first-use.tstest/type-check/v19-subpaths.tstest/unit/CasFirstMemoization.test.tstest/unit/application/WarpStorageRegistry.test.tstest/unit/cli/doctor.test.tstest/unit/cli/schemas.test.tstest/unit/domain/ReceiptDiagnostics.test.tstest/unit/domain/WarpApp.facade.test.tstest/unit/domain/WarpCore.apiSurface.test.tstest/unit/domain/WarpCore.blobAutoConstruct.test.tstest/unit/domain/WarpCore.effectPipeline.test.tstest/unit/domain/WarpCore.emit.test.tstest/unit/domain/WarpCore.stateSessionAutoConstruct.test.tstest/unit/domain/WarpFacade.test.tstest/unit/domain/WarpGraph.audit.test.tstest/unit/domain/WarpGraph.content.test.tstest/unit/domain/WarpGraph.coverageGaps.test.tstest/unit/domain/WarpWorldline.test.tstest/unit/domain/internalReadingSurface.behavior.test.tstest/unit/domain/runtimeProductExecutableSurface.test.tstest/unit/domain/seekCache.test.tstest/unit/domain/services/AuditReceiptService.coverage.test.tstest/unit/domain/services/AuditReceiptService.test.tstest/unit/domain/services/AuditVerifierService.bench.tstest/unit/domain/services/AuditVerifierService.test.tstest/unit/domain/services/BitmapIndexReader.chunked.test.tstest/unit/domain/services/HealthCheckService.test.tstest/unit/domain/services/IndexRebuildService.deep.test.tstest/unit/domain/services/IndexRebuildService.streaming.test.tstest/unit/domain/services/IndexRebuildService.test.tstest/unit/domain/services/IndexStalenessChecker.test.tstest/unit/domain/services/StreamingBitmapIndexBuilder.chunked.test.tstest/unit/domain/services/StreamingBitmapIndexBuilder.test.tstest/unit/domain/services/TreeConstruction.determinism.test.tstest/unit/domain/services/controllers/ForkController.test.tstest/unit/domain/services/controllers/IntentController.test.tstest/unit/domain/services/controllers/MaterializeController.test.tstest/unit/domain/services/controllers/StrandController.host-interface.test.tstest/unit/domain/services/logging.integration.test.tstest/unit/domain/services/optic/CheckpointPatchFactStream.test.tstest/unit/domain/services/optic/CheckpointShardFactReader.manifest.test.tstest/unit/domain/services/optic/CheckpointTailBasisVerifier.test.tstest/unit/domain/services/optic/CoordinateCheckpointTailOpticSource.test.tstest/unit/domain/services/optic/StreamingCheckpointBasisBuilder.test.tstest/unit/domain/services/optic/TraversalOptic.test.tstest/unit/domain/services/optic/WorldlineOptic.test.tstest/unit/domain/services/strand/StrandService.test.tstest/unit/domain/strandAndRuntimeSeams.test.tstest/unit/domain/utils/CachedValue.test.tstest/unit/domain/utils/RefLayout.test.tstest/unit/domain/warp/RuntimeHostPortResolvers.test.tstest/unit/domain/warp/Writer.sameWriterRace.test.tstest/unit/domain/warp/buildView.test.tstest/unit/domain/warp/hydrateCheckpointIndex.regression.test.tstest/unit/domain/worldlineExecutableExamples.test.tstest/unit/domain/worldlineReadExecutablePaths.test.tstest/unit/helpers/MockStreamingIndexStorage.test.tstest/unit/infrastructure/CasIndexStorageAdapter.streamingIndexBuilder.test.tstest/unit/infrastructure/CasIndexStorageAdapter.test.tstest/unit/infrastructure/adapters/CasSeekCacheAdapter.eviction.test.tstest/unit/infrastructure/adapters/CasSeekCacheAdapter.test.tstest/unit/infrastructure/adapters/GitCasRepositoryAdapter.test.tstest/unit/infrastructure/adapters/InMemoryBlobStorageAdapter.test.tstest/unit/infrastructure/adapters/InMemoryGraphAdapter.browser.test.tstest/unit/infrastructure/adapters/InMemoryGraphAdapter.integration.test.tstest/unit/infrastructure/adapters/InMemoryGraphAdapter.pathKeys.test.tstest/unit/infrastructure/adapters/InMemoryGraphAdapter.test.tstest/unit/infrastructure/adapters/inMemoryHashing.test.tstest/unit/infrastructure/adapters/sha1sync.test.tstest/unit/ports/RefPort.compareAndSwapRef.test.tstest/unit/ports/SeekCachePort.test.tstest/unit/scripts/checkpoint-schema-upgrade.test.tstest/unit/scripts/storage-ownership-boundary.test.tstest/unit/scripts/v16-to-v17-upgrade.test.tstest/unit/scripts/v19-public-api-boundary.test.tstest/unit/v7-guards.test.ts
💤 Files with no reviewable changes (58)
- test/unit/ports/SeekCachePort.test.ts
- test/unit/infrastructure/CasIndexStorageAdapter.test.ts
- test/helpers/MockStreamingIndexStorage.ts
- test/unit/domain/services/IndexRebuildService.streaming.test.ts
- test/unit/infrastructure/CasIndexStorageAdapter.streamingIndexBuilder.test.ts
- test/unit/infrastructure/adapters/sha1sync.test.ts
- test/unit/domain/services/StreamingBitmapIndexBuilder.chunked.test.ts
- test/unit/helpers/MockStreamingIndexStorage.test.ts
- test/unit/infrastructure/adapters/CasSeekCacheAdapter.eviction.test.ts
- test/unit/domain/services/IndexStalenessChecker.test.ts
- test/unit/domain/services/HealthCheckService.test.ts
- test/unit/CasFirstMemoization.test.ts
- src/infrastructure/adapters/CasIndexStorageAdapter.ts
- test/unit/infrastructure/adapters/inMemoryHashing.test.ts
- test/unit/domain/services/IndexRebuildService.deep.test.ts
- test/unit/domain/services/optic/StreamingCheckpointBasisBuilder.test.ts
- src/ports/StreamingIndexStoragePort.ts
- src/domain/services/HealthCheckService.ts
- test/unit/domain/warp/hydrateCheckpointIndex.regression.test.ts
- src/domain/runtimeHelpers.ts
- src/application/WarpStorageRegistry.ts
- src/domain/utils/seekCacheKey.ts
- test/unit/infrastructure/adapters/CasSeekCacheAdapter.test.ts
- test/unit/domain/utils/CachedValue.test.ts
- src/domain/services/materialize/CasFirstMemoizationEngine.ts
- test/unit/domain/seekCache.test.ts
- src/domain/services/optic/StreamingCheckpointBasisBuilder.ts
- src/domain/services/index/IndexStalenessChecker.ts
- test/unit/domain/services/StreamingBitmapIndexBuilder.test.ts
- bin/cli/types.ts
- scripts/source-version-name-policy.ts
- src/domain/utils/CachedValue.ts
- src/infrastructure/adapters/GitCasRepositoryAdapter.ts
- src/ports/SeekCachePort.ts
- src/domain/services/index/IndexRebuildService.ts
- test/unit/domain/services/strand/StrandService.test.ts
- test/helpers/mockHost.ts
- test/unit/infrastructure/adapters/InMemoryGraphAdapter.browser.test.ts
- test/unit/domain/services/logging.integration.test.ts
- src/infrastructure/adapters/CasSeekCacheAdapter.ts
- src/infrastructure/adapters/sha1sync.ts
- src/domain/services/index/StreamingBitmapIndexBuilder.ts
- src/domain/services/controllers/ForkController.ts
- eslint.config.ts
- test/unit/domain/services/IndexRebuildService.test.ts
- test/unit/domain/services/controllers/MaterializeController.test.ts
- test/unit/cli/doctor.test.ts
- test/unit/domain/utils/RefLayout.test.ts
- test/unit/domain/WarpGraph.coverageGaps.test.ts
- bin/warp-graph.ts
- storage.ts
- test/unit/domain/services/controllers/ForkController.test.ts
- src/domain/warp/RuntimeHostProduct.ts
- src/domain/utils/RefLayout.ts
- src/domain/WarpCore.ts
- src/domain/warp/WarpCoreRuntimeProduct.ts
- src/domain/RuntimeHost.ts
- src/domain/warp/RuntimeHostBoot.ts
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: preflight
- GitHub Check: test-node (22)
- GitHub Check: coverage-threshold
🧰 Additional context used
📓 Path-based instructions (4)
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
**/*.{ts,tsx,js,jsx}: Do not use direct imports fromsrc/infrastructure/**insrc/domain/**orsrc/ports/**; depend on a port instead.
Do not use direct Node built-ins insrc/domain/**orsrc/ports/**; use a port instead.
Files:
test/conformance/v18BoundedMemoryLargeGraphGate.test.tstest/unit/ports/RefPort.compareAndSwapRef.test.tstest/unit/domain/WarpApp.facade.test.tstest/unit/domain/worldlineReadExecutablePaths.test.tsscripts/check-source-backed-reference.tstest/unit/scripts/storage-ownership-boundary.test.tstest/unit/domain/WarpFacade.test.tstest/unit/domain/WarpGraph.audit.test.tstest/unit/domain/runtimeProductExecutableSurface.test.tstest/conformance/v18CoordinateOpticPublicPath.test.tstest/unit/domain/services/AuditVerifierService.bench.tstest/benchmark/detachedReadBenchmark.fixture.tstest/unit/domain/services/BitmapIndexReader.chunked.test.tstest/unit/domain/WarpCore.apiSurface.test.tstest/unit/domain/services/optic/CheckpointPatchFactStream.test.tstest/unit/domain/WarpGraph.content.test.tstest/conformance/fixtures/V17CheckpointTailOpticGraphFixture.tstest/unit/domain/services/AuditReceiptService.test.tstest/unit/domain/internalReadingSurface.behavior.test.tstest/unit/domain/services/TreeConstruction.determinism.test.tstest/unit/application/WarpStorageRegistry.test.tstest/unit/domain/services/optic/WorldlineOptic.test.tstest/unit/scripts/v19-public-api-boundary.test.tstest/unit/domain/warp/RuntimeHostPortResolvers.test.tstest/unit/domain/WarpCore.stateSessionAutoConstruct.test.tstest/type-check/v19-first-use.tstest/unit/domain/ReceiptDiagnostics.test.tstest/unit/domain/worldlineExecutableExamples.test.tstest/helpers/WarpGraphTestRepositories.tstest/helpers/inMemoryHashing.tstest/helpers/MemoryStorage.tstest/unit/infrastructure/adapters/InMemoryGraphAdapter.integration.test.tstest/unit/infrastructure/adapters/InMemoryGraphAdapter.test.tstest/unit/infrastructure/adapters/InMemoryGraphAdapter.pathKeys.test.tstest/unit/domain/services/optic/CheckpointShardFactReader.manifest.test.tstest/conformance/post-v17/graphQueryBoundedProvider.blocked.test.tstest/type-check/v19-consumer.tstest/unit/domain/warp/Writer.sameWriterRace.test.tstest/unit/scripts/v16-to-v17-upgrade.test.tstest/unit/domain/services/AuditVerifierService.test.tstest/unit/domain/WarpCore.effectPipeline.test.tstest/unit/domain/services/optic/TraversalOptic.test.tssrc/domain/services/PatchBuilder.tstest/unit/domain/services/optic/CoordinateCheckpointTailOpticSource.test.tstest/unit/domain/services/AuditReceiptService.coverage.test.tstest/unit/domain/WarpCore.emit.test.tstest/unit/domain/WarpWorldline.test.tstest/unit/domain/services/optic/CheckpointTailBasisVerifier.test.tstest/unit/domain/WarpCore.blobAutoConstruct.test.tstest/unit/domain/services/controllers/StrandController.host-interface.test.tstest/helpers/MockIndexStorage.tstest/helpers/MemoryRuntimeHost.tstest/unit/v7-guards.test.tstest/conformance/v18FirstUseOpticsHonesty.test.tstest/helpers/BoundedReadBasis.tstest/unit/domain/warp/buildView.test.tsbin/cli/commands/check.tstest/unit/scripts/checkpoint-schema-upgrade.test.tstest/unit/infrastructure/adapters/GitCasRepositoryAdapter.test.tstest/unit/domain/services/controllers/IntentController.test.tstest/helpers/MemoryRuntimeStorageAdapter.tstest/unit/infrastructure/adapters/InMemoryBlobStorageAdapter.test.tstest/type-check/v19-subpaths.tsbin/cli/commands/doctor/checks.tssrc/domain/WarpGraph.tstest/unit/domain/strandAndRuntimeSeams.test.tstest/helpers/InMemoryGraphAdapter.tstest/unit/cli/schemas.test.tssrc/domain/services/controllers/IntentController.tsbin/cli/schemas.tstest/helpers/InMemoryBlobStorageAdapter.tssrc/domain/services/controllers/detachedOpen.tsbin/cli/shared.tsbin/cli/commands/seek.ts
src/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/**/*.{ts,tsx,js,jsx}: Do not introduceany,as any,as unknown as,unknown(outside adapters),Record<string, unknown>(outside adapters),*Likeplaceholder types,JSON.parse/JSON.stringify(outside adapters),fetch(outside adapters),process.env(outside adapters),@ts-ignore, orz.any()in core code; use validated boundary models and ports instead.
Use constructor-injected ports for external capabilities; do not rely on ambient dependencies for I/O, clocks, persistence, or entropy.
Do not createutils.ts,helpers.ts,misc.ts, orcommon.ts; name files after the actual concept they model.
Prefer one file per class, type, or object; if a file accumulates peer concepts, split it.
Keep helper corridors, fake shape trust, transitional duplication, and compile-time theater out of the codebase; runtime-honest TypeScript must reflect actual behavior.
No enum usage; prefer runtime-backed domain forms and unions.
Do not use boolean trap parameters; prefer named option objects or separate methods.
Avoid magic strings or numbers when a named constant should exist.
Keep domain bytes asUint8Array;Bufferbelongs in infrastructure adapters.
Files:
src/domain/services/PatchBuilder.tssrc/domain/WarpGraph.tssrc/domain/services/controllers/IntentController.tssrc/domain/services/controllers/detachedOpen.ts
src/domain/**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
src/domain/**/*.{ts,tsx,js,jsx}: Insrc/domain/**, do not useDate.now(),new Date(),Date(),performance.now(),Math.random(),crypto.randomUUID(),crypto.getRandomValues(),setTimeout,setInterval, rawnew Error(...)/new TypeError(...), or direct imports from Node built-ins; time, entropy, and external capabilities must enter through ports or parameters, and domain errors should extendWarpError.
Construct domain objects only in core when doing so establishes validated runtime truth; do not build infrastructure adapters, host APIs, persistence implementations, wall clocks, or entropy sources inside core.
Prefer discriminated unions and explicit result types instead of boolean-flag bags, and model expected failures as return values rather than exceptions.
src/domain/must not import host APIs or Node-specific globals; hexagonal architecture boundaries are mandatory.
Domain code must not use the wall clock directly; time must enter through a port or parameter.
Files:
src/domain/services/PatchBuilder.tssrc/domain/WarpGraph.tssrc/domain/services/controllers/IntentController.tssrc/domain/services/controllers/detachedOpen.ts
src/domain/**/!(*.test).{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (AGENTS.md)
Use explicit domain concepts with validated constructors,
Object.freeze, andinstanceofdispatch; domain objects should be runtime-backed nouns, not ad hoc shape bags.
Files:
src/domain/services/PatchBuilder.tssrc/domain/WarpGraph.tssrc/domain/services/controllers/IntentController.tssrc/domain/services/controllers/detachedOpen.ts
🔇 Additional comments (88)
bin/cli/commands/check.ts (1)
8-30: LGTM!bin/cli/commands/doctor/checks.ts (1)
36-53: LGTM!bin/cli/commands/seek.ts (1)
17-17: LGTM!Also applies to: 247-410
bin/cli/schemas.ts (1)
138-147: LGTM!Also applies to: 154-162, 184-190, 237-245, 248-259
bin/cli/shared.ts (2)
24-31: LGTM!Also applies to: 97-113
39-42: 🩺 Stability & AvailabilityNo extra
runtimeStorageguard needed.runtimeStorageis required byWarpStorageBindingand is always bound inGitStorage.open(), so this check would be redundant.> Likely an incorrect or invalid review comment.src/domain/WarpGraph.ts (1)
33-34: LGTM!Also applies to: 136-136, 167-172
src/domain/services/controllers/detachedOpen.ts (1)
13-14: LGTM!Also applies to: 32-33, 50-51, 77-80, 103-103
test/unit/domain/services/controllers/IntentController.test.ts (1)
1-41: LGTM!src/domain/services/controllers/IntentController.ts (2)
11-15: LGTM!
28-40: 🗄️ Data Integrity & Integration
shais fine as a local admission id.admitIntent()is a compatibility admission surface, not a durable write path, so the counter-based value here is acceptable.> Likely an incorrect or invalid review comment.src/domain/services/PatchBuilder.ts (1)
285-285: LGTM!Also applies to: 323-323
test/benchmark/detachedReadBenchmark.fixture.ts (1)
6-6: LGTM!test/helpers/InMemoryBlobStorageAdapter.ts (2)
2-20: LGTM!Also applies to: 34-34
21-24: 🩺 Stability & AvailabilityNo fallback needed here The test suite runs on Node 22+, and this helper is only used in Node unit tests, so
globalThis.crypto.subtleis available.> Likely an incorrect or invalid review comment.test/helpers/MemoryRuntimeHost.ts (1)
6-6: LGTM!test/helpers/MemoryRuntimeStorageAdapter.ts (1)
1-14: LGTM!test/helpers/MockIndexStorage.ts (1)
1-62: LGTM!test/unit/domain/services/BitmapIndexReader.chunked.test.ts (1)
3-3: LGTM!Also applies to: 18-18
test/conformance/fixtures/V17CheckpointTailOpticGraphFixture.ts (1)
1-1: LGTM!test/conformance/post-v17/graphQueryBoundedProvider.blocked.test.ts (1)
3-3: LGTM!test/conformance/v18BoundedMemoryLargeGraphGate.test.ts (1)
5-5: LGTM!test/conformance/v18CoordinateOpticPublicPath.test.ts (1)
2-2: LGTM!test/conformance/v18FirstUseOpticsHonesty.test.ts (1)
10-11: LGTM!test/helpers/InMemoryGraphAdapter.ts (1)
7-19: LGTM!test/helpers/BoundedReadBasis.ts (1)
2-2: LGTM!test/helpers/MemoryStorage.ts (1)
1-19: LGTM!test/helpers/WarpGraphTestRepositories.ts (1)
6-6: LGTM!test/helpers/inMemoryHashing.ts (1)
7-9: LGTM!test/unit/domain/services/TreeConstruction.determinism.test.ts (1)
12-13: LGTM!ARCHITECTURE.md (1)
30-30: LGTM!Also applies to: 208-211, 220-225
docs/TECHNICAL_TEARDOWN.md (1)
171-188: LGTM!Also applies to: 275-276, 1463-1466
test/unit/domain/internalReadingSurface.behavior.test.ts (1)
11-11: LGTM!test/unit/domain/runtimeProductExecutableSurface.test.ts (1)
4-4: LGTM!test/unit/domain/services/AuditReceiptService.coverage.test.ts (1)
11-11: LGTM!test/unit/domain/worldlineReadExecutablePaths.test.ts (1)
3-3: LGTM!test/unit/infrastructure/adapters/GitCasRepositoryAdapter.test.ts (1)
131-135: LGTM!Also applies to: 168-169
docs/migrations/v19/README.md (1)
248-248: LGTM!docs/topics/api/README.md (1)
431-431: LGTM!docs/topics/reference.md (2)
90-105: LGTM!
195-195: LGTM!docs/topics/unmaterialized-intents.md (4)
29-31: LGTM!
39-39: LGTM!
59-60: LGTM!
70-70: LGTM!scripts/check-source-backed-reference.ts (1)
267-267: LGTM!scripts/smoke-packed-artifact.sh (1)
48-56: LGTM!test/unit/domain/services/AuditVerifierService.test.ts (1)
10-10: LGTM!test/unit/domain/warp/Writer.sameWriterRace.test.ts (1)
2-2: LGTM!test/type-check/v19-consumer.ts (1)
37-40: LGTM!
Switching toGitStorage.open({ cwd: '.' })matches theWarpStoragecontract exercised byopenWarpandpublicStorage, consistent with removingMemoryStoragefrom the public storage subpath.test/type-check/v19-first-use.ts (1)
9-14: LGTM!test/type-check/v19-subpaths.ts (1)
8-8: LGTM!Also applies to: 20-33
test/unit/application/WarpStorageRegistry.test.ts (1)
4-4: LGTM!test/unit/cli/schemas.test.ts (1)
254-257: LGTM!
Coverage now asserts the removed cache flags fail schema validation, matching the removal of seek-cache CLI wiring described in the PR objectives.test/unit/domain/ReceiptDiagnostics.test.ts (1)
10-10: LGTM!test/unit/infrastructure/adapters/InMemoryBlobStorageAdapter.test.ts (2)
3-3: LGTM!
127-128: 🎯 Functional CorrectnessNo fallback-hash branch remains
test/helpers/InMemoryBlobStorageAdapter.tsnow always uses Web Crypto SHA-256, so removing the fallback test is fine.> Likely an incorrect or invalid review comment.test/unit/infrastructure/adapters/InMemoryGraphAdapter.integration.test.ts (1)
2-2: LGTM!test/unit/domain/WarpApp.facade.test.ts (1)
5-5: LGTM!test/unit/domain/WarpCore.apiSurface.test.ts (1)
3-3: LGTM!test/unit/domain/WarpCore.blobAutoConstruct.test.ts (1)
4-4: LGTM!test/unit/domain/WarpCore.effectPipeline.test.ts (1)
7-7: LGTM!test/unit/domain/WarpCore.emit.test.ts (1)
4-4: LGTM!test/unit/domain/services/optic/TraversalOptic.test.ts (1)
18-18: LGTM!test/unit/domain/services/optic/WorldlineOptic.test.ts (1)
19-19: LGTM!test/unit/domain/strandAndRuntimeSeams.test.ts (1)
11-12: LGTM!Also applies to: 139-139, 179-179
test/unit/domain/WarpCore.stateSessionAutoConstruct.test.ts (1)
7-7: LGTM!test/unit/domain/WarpFacade.test.ts (1)
18-18: LGTM!test/unit/domain/WarpGraph.audit.test.ts (1)
10-10: LGTM!test/unit/domain/WarpGraph.content.test.ts (1)
230-231: LGTM!test/unit/domain/WarpWorldline.test.ts (1)
3-3: LGTM!test/unit/domain/warp/RuntimeHostPortResolvers.test.ts (1)
11-12: LGTM!test/unit/domain/warp/buildView.test.ts (1)
2-2: LGTM!test/unit/domain/worldlineExecutableExamples.test.ts (1)
7-7: LGTM!test/unit/domain/services/AuditReceiptService.test.ts (1)
21-21: LGTM!test/unit/domain/services/AuditVerifierService.bench.ts (1)
9-9: LGTM!test/unit/domain/services/controllers/StrandController.host-interface.test.ts (1)
7-7: LGTM!test/unit/domain/services/optic/CheckpointPatchFactStream.test.ts (1)
27-27: LGTM!test/unit/domain/services/optic/CheckpointShardFactReader.manifest.test.ts (1)
23-23: LGTM!test/unit/domain/services/optic/CheckpointTailBasisVerifier.test.ts (1)
15-15: LGTM!test/unit/domain/services/optic/CoordinateCheckpointTailOpticSource.test.ts (1)
11-11: LGTM!test/unit/infrastructure/adapters/InMemoryGraphAdapter.pathKeys.test.ts (1)
2-2: LGTM!test/unit/infrastructure/adapters/InMemoryGraphAdapter.test.ts (1)
6-6: LGTM!test/unit/ports/RefPort.compareAndSwapRef.test.ts (1)
2-2: LGTM!test/unit/scripts/checkpoint-schema-upgrade.test.ts (1)
2-2: LGTM!test/unit/scripts/v16-to-v17-upgrade.test.ts (1)
7-7: LGTM!test/unit/scripts/v19-public-api-boundary.test.ts (1)
214-214: LGTM!test/unit/v7-guards.test.ts (1)
5-5: LGTM!
Self-review at
|
Code Lawyer audit at
|
Release Preflight
If this PR is from a |
Release Preflight
If this PR is from a |
Review-fix self-review at
|
Code Lawyer delta at
|
Release Preflight
If this PR is from a |
1 participant
Summary
test/helpersand removeMemoryStoragefrom the public storage subpathThe v16-to-v17 migration that deletes historical
seek-cacherefs remains intact for existing repositories.Validation
npm run test:local: 558 files passed, 1 skipped; 7,163 tests passed, 2 skippednpm run typechecknpm run typecheck:consumernpm run typecheck:surfacenpm run lintnpm run lint:mdnpm run lint:docs-topologynpm run lint:source-version-namesnpm run lint:semgrepnpm run lint:contaminationbash scripts/smoke-packed-artifact.she5d3dc4cae0bce05f369b4d4ef3be8a51911e56aCloses #736