webui: fix ?model= URL param race in router mode#22771
Merged
allozaur merged 2 commits intoggml-org:masterfrom May 7, 2026
Merged
webui: fix ?model= URL param race in router mode#22771allozaur merged 2 commits intoggml-org:masterfrom
allozaur merged 2 commits intoggml-org:masterfrom
Conversation
Contributor
Author
|
We could assign the store sole responsibility for fetching at startup, and it would be the source of truth for everything else. This applies to both the query parameter and the automatic selection of the currently loaded model. |
allozaur
approved these changes
May 6, 2026
Contributor
yeah, in general i am re-reviewing some of the ways we initialize some of the stores/services and i'd consider doing what u suggest as well. but for this PR let's focus only on solving the race condition |
ggerganov
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes automatic model selection with the URL query parameter ?model=xxx
Additional information
Initial fix without refactoring, cc @alek, This is just the race fix and I tested it in router mode.
But I'm sure we can do better in terms of architecture so as not to have any race at all. And we can also add alias support.
fix-model-url-param-race.mp4
Solve #22324
Requirements