server: fix /infill prompt placement after FIM_MID#22761
Open
Aayush7g wants to merge 1 commit intoggml-org:masterfrom
Open
server: fix /infill prompt placement after FIM_MID#22761Aayush7g wants to merge 1 commit intoggml-org:masterfrom
Aayush7g wants to merge 1 commit intoggml-org:masterfrom
Conversation
The 'prompt' field was incorrectly appended to tokens_prefix, placing it before FIM_SUF and FIM_MID. This caused the model to treat it as part of the prefix (code above cursor) instead of a generation primer after FIM_MID. Fix: move tokens_prompt insertion to after embd_inp.push_back(FIM_MID). Fixes ggml-org#22678
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'prompt' field was incorrectly appended to tokens_prefix, placing it before FIM_SUF and FIM_MID. This caused the model to treat it as part of the prefix (code above cursor) instead of a generation primer after FIM_MID.
Fix: move tokens_prompt insertion to after embd_inp.push_back(FIM_MID).
Fixes #22678
Overview
Additional information
Requirements