[ggml] fix vulkan spv shadowing#22760
Merged
0cc4m merged 1 commit intoggml-org:masterfrom May 8, 2026
Merged
Conversation
jeffbolznv
approved these changes
May 6, 2026
0cc4m
approved these changes
May 8, 2026
Contributor
0cc4m
left a comment
There was a problem hiding this comment.
LGTM, thank you for the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
I found build errors on arm64 when I update ggml to 0.11.0 microsoft/vcpkg#51551
The failure is caused by a local variable named
spvinggml-vulkan.cpp, which shadows thespvnamespace from SPIR-V Headers. As a result, references such asspv::OpCodeMask,spv::WordCountShift, andspv::OpCapabilitymay be resolved against the local variable instead of the namespace and fail to compile.This patch renames the local SPIR-V word buffer to avoid the name conflict.
Requirements