fix(core): Use more checked arithmetic, part 2b#9425
Open
andyleiserson wants to merge 1 commit intogfx-rs:trunkfrom
Open
fix(core): Use more checked arithmetic, part 2b#9425andyleiserson wants to merge 1 commit intogfx-rs:trunkfrom
andyleiserson wants to merge 1 commit intogfx-rs:trunkfrom
Conversation
14b890f to
f1478f5
Compare
f1478f5 to
426d4cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #9363 to address comments and add changelog entry.
This changes
align_toto always panic if it would overflow (and removes assertions that did that in specific instances). Other than that, it should just be changing error reporting behavior.Squash or Rebase? Squash
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.