Don't fail metal create_fence if no shared event could be created#9415
Open
Wumpf wants to merge 2 commits intogfx-rs:trunkfrom
Open
Don't fail metal create_fence if no shared event could be created#9415Wumpf wants to merge 2 commits intogfx-rs:trunkfrom
create_fence if no shared event could be created#9415Wumpf wants to merge 2 commits intogfx-rs:trunkfrom
Conversation
Wumpf
added
the
PR: needs back-porting
Wumpf
force-pushed
the
handle-metal-shared-event-failure
branch
from
de561a8 to
e345251
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an unnecessary unwrap that messes with may sandboxing.
Usecase is that I ran more and more AI agents in sandboxing. My sandbox interface of choice,
nono, recently added an--allow-gpuoption and it works just fine, except for creation of shared events, which when you think about it makes a lot of sense.Testing
With this I can run wgpu examples in my
nonosandbox profile with--allow-gpu- presentation interestingly fails sildently, so I end up an empty window. But don't care for my current purposes!Confirmed that Rerun image comparision tests work with this.
Squash or Rebase?
s