Skip to content

fix(metal): use isVisible instead of occlusionState for window visibility check #9410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
intel352 wants to merge 1 commit into
base: trunk
Choose a base branch
from
+12 −4
Open

fix(metal): use isVisible instead of occlusionState for window visibility check #9410

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions wgpu-hal/src/metal/surface.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,18 @@ impl crate::Surface for super::Surface {
unsafe { objc2::msg_send![&*delegate, window] };

if let Some(window) = window {
const NS_WINDOW_OCCLUSION_STATE_VISIBLE: usize = 1 << 1;
let occlusion_state: usize =
unsafe { objc2::msg_send![&*window, occlusionState] };
let is_visible = (occlusion_state & NS_WINDOW_OCCLUSION_STATE_VISIBLE) != 0;
// Use `isVisible` instead of `occlusionState` to determine
// if the window can be rendered to. `occlusionState` does not
// have the `NSWindowOcclusionStateVisible` bit set when the
// app is launched from Terminal or another CLI environment on
// macOS, causing `get_current_texture()` to return `Occluded`
// indefinitely — even though the window is on-screen and
// interactive. `isVisible` correctly reflects the window's
// actual visibility in all launch contexts.
//
// See: https://github.com/gfx-rs/wgpu/issues/8309
let is_visible: bool =
unsafe { objc2::msg_send![&*window, isVisible] };

if !is_visible {
return Err(crate::SurfaceError::Occluded);
Expand Down
Loading