Use llvm-cov show-env for cts_runner integration tests#9401
Open
andyleiserson wants to merge 1 commit intogfx-rs:trunkfrom
Open
Use llvm-cov show-env for cts_runner integration tests#9401andyleiserson wants to merge 1 commit intogfx-rs:trunkfrom
llvm-cov show-env for cts_runner integration tests#9401andyleiserson wants to merge 1 commit intogfx-rs:trunkfrom
Conversation
6f3d56f to
e0129a8
Compare
llvm-cov show-env for cts_runner integration tests
92f9092 to
b542bcf
Compare
b542bcf to
cfd7cb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
May help with #9402, or it may not, I'm not really sure.
The CTS jobs, as the name suggests, run CTS tests. The "other" CTS jobs additionally run the Rust integration tests for
cts_runner. Previously, the xtask usedllvm-cov show-envso we can run the binary directly instead of via cargo, which makes the runs much faster. But the integration tests were still usingcargo llvm-cov run. Theshow-envmethod puts build products in their usual locations intarget, whilellvm-cov runputs them in something liketarget/llvm-cov-target.I have two theories of #9402. The one relevant here is that things are generally unhappy switching between the two build directories, so to try and avoid any problems of that sort, this configures the CTS jobs to consistently use
show-env.(The other theory is that when the GitHub actions cache gets saved from a non-"other" job and then used to run the "other", something gets confused about the incremental build state, resulting in the
v8link error. #9403 addressed this by saving caches only from the "other" CTS jobs. (And also only on trunk, but that part is an unrelated optimization.))Testing
CI, but it's not clear what the precise conditions are for #9402 to show up.
Squash or Rebase? Squash