[naga msl-out] Remove unnecessary pub from Writer fields.#9395
Open
jimblandy wants to merge 1 commit intogfx-rs:trunkfrom
Open
[naga msl-out] Remove unnecessary pub from Writer fields.#9395jimblandy wants to merge 1 commit intogfx-rs:trunkfrom
pub from Writer fields.#9395jimblandy wants to merge 1 commit intogfx-rs:trunkfrom
Conversation
In `naga::back::msl::writer`, remove `pub(super)` visibility from fields that are not actually used outside the module.
jimblandy
added
naga
inner-daemons
approved these changes
Apr 8, 2026
Collaborator
inner-daemons
left a comment
inner-daemons
left a comment
There was a problem hiding this comment.
Oops, but yeah lgtm
Contributor
|
Fwiw, #9304 might also undo some of this (but it also leaves some fields w/o |
Member
|
@jimblandy: Please rebase and resolve conflicts! 🙏🏻 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
naga::back::msl::writer, removepub(super)visibility from fields that are not actually used outside the module.