Conversation
ErichDonGubler
left a comment
There was a problem hiding this comment.
There are no tests, here, but if we need a fix, we need tests, too! Will you please add some tests (preferably snapshot tests emitting the "wrong" code from before) and then amend the current commit to add the snapshot changes?
ErichDonGubler
left a comment
There was a problem hiding this comment.
This also needs a CHANGELOG entry.
|
@ErichDonGubler i did the changes, i can't have an old snapshot because naga would crash |
|
Could you explain what this fix is actually doing, I'm not sure I understand it |
|
@cwfitzgerald
and lastly create a new object that is aligned correctly. |
|
I'm gonna unassign myself since I'm not too familiar with this part of the codebase. Up to you @cwfitzgerald. |
Connections
#9011
Description
fix mat2xc alignment issues in spv when using uniforms, fix issues with uniform array as well
Testing
Explain how this change is tested.
Squash or Rebase?
either
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.