Conversation
6e7f56a to
1394e40
Compare
1394e40 to
23cd6ab
Compare
ec1eb90 to
494a4e1
Compare
| @@ -276,60 +361,20 @@ impl Surface { | |||
| pub fn present(&self) -> Result<Status, SurfaceError> { | |||
There was a problem hiding this comment.
Could you move present fully on the queue (removing this function and Global::surface_present)? It's odd to have it in both places now.
There was a problem hiding this comment.
I had to keep Global::surface_present because deno uses it, and theres no way to get at the Queue itself afaict in deno. Addressed the rest though
494a4e1 to
fd1a2be
Compare
|
@teoxoy I redid the commits, but a lot of them are the same as before. The relevant ones are the 1st commit (new) and the 6th commit (amended). The 4th and 7th commits were split out of that commit, 4 6 and 7 used to be all one commit. 5 is also a new commit, opportunistically avoiding removing the error sink due to dead code warning by instead just using it in a place it should be used P.S. Hiding whitespace in the 1st commit is both useful and hurtful, try looking at the commit in both modes. |
|
@atlv24 Can you list out the things that have changed from my thing to yours? |
|
The PR description says whats different, its up to date. I recommend just reviewing commit by commit, there's not really a point in comparing the PRs at this point i believe |
9d513dd to
ea3cc7e
Compare
|
Two new commits, the last couple fix(core):'s |
teoxoy
left a comment
There was a problem hiding this comment.
Thanks for making this easy to review! I have 2 last comments.
ea3cc7e to
904e540
Compare
|
Fixed the two feedback items and rebased on trunk, should be good to go now |
Connections
Supersedes #9222
Fixes #6748
Fixes #9109
Progress towards #4098
Description
Redoes #9222 in the way @teoxoy suggested, we use the last submissions fence index instead of giving presents their own index. also clean git history and adding some safety comments and a repro test while we're at it.
Also factors out a shared part of submit as suggested in #9307
Testing
Repro case added, it fails before the fix and passes after the fix.
Squash or Rebase?
Rebase, the commits are clean and each compile etc.
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.