Skip to content

Implement: Examine the apply_cli_overrides method implementation #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tross-agent wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −0
Open

Implement: Examine the apply_cli_overrides method implementation #1386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions mcp_server/src/config/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,10 @@ def apply_cli_overrides(self, args) -> None:
# Override server settings
if hasattr(args, 'transport') and args.transport:
self.server.transport = args.transport
if hasattr(args, 'host') and args.host:
self.server.host = args.host
if hasattr(args, 'port') and args.port is not None:
self.server.port = args.port

# Override LLM settings
if hasattr(args, 'llm_provider') and args.llm_provider:
Expand Down
4 changes: 4 additions & 0 deletions mcp_server/tests/test_configuration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,8 @@ def test_cli_override():
class Args:
config = Path('config.yaml')
transport = 'stdio'
host = '127.0.0.1'
port = 8080
llm_provider = 'anthropic'
model = 'claude-3-sonnet'
temperature = 0.5
Expand All @@ -167,6 +169,8 @@ class Args:

print('✓ CLI overrides applied successfully')
print(f' - Transport: {config.server.transport}')
print(f' - Host: {config.server.host}')
print(f' - Port: {config.server.port}')
print(f' - LLM provider: {config.llm.provider}')
print(f' - LLM model: {config.llm.model}')
print(f' - Temperature: {config.llm.temperature}')
Expand Down
Loading