Implement 'forget' functionality to selectively delete nodes and edges from the graph#1369
Implement 'forget' functionality to selectively delete nodes and edges from the graph#1369dudo wants to merge 2 commits intogetzep:mainfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
PR Triage AssessmentPriority: LOW | Category: feature | Action: needs-major-rework SummaryAdds a "forget" endpoint to the REST API and MCP server that searches for nodes/edges by semantic query and deletes them. The core logic is reasonable, but the PR bundles an unrelated company-specific Dockerfile and lacks any tests. Quality Scores
Signals
Maintainer NoteBefore this can be merged: (1) Remove Raw triage data (JSON){
"pr_number": 1369,
"title": "Implement 'forget' functionality to selectively delete nodes and edges from the graph",
"author": "dudo",
"category": "feature",
"priority": "LOW",
"action": "needs-major-rework",
"quality_scores": {
"tests": 0,
"docs": 1,
"style": 2,
"scope": 2,
"total": 5
},
"signals": {
"follows_patterns": true,
"focused_scope": false,
"has_rfc_if_needed": true
},
"slop_signals": ["tests-missing"],
"duplicate_of": null,
"additions": 196,
"deletions": 2,
"files_changed": 5,
"linked_issue": 864,
"notes": "Dockerfile.local with company-specific artifactory URL (artifactory.legalzoom.com) should be removed. Core forget implementation looks reasonable but needs test coverage."
} |
Note on test coverageQuick survey of the existing test landscape:
The forget implementation is a thin composition of existing tested primitives ( |
|
I see the use case here for the MCP server, but not for building this into Graphiti. See my comment in the related issue. Can we move this functionality entirely into the MCP server? |
|
@danielchalef Makes sense — forget is use-case dependent and better as an implementation detail than a core primitive. Updated the PR:
Will amend the commit once I confirm the changes look right. |
|
I'm trying to test this against my deployment. As an http server, I'm expecting the graphiti server to expose the /mcp endpoint, but it's not there. Does the server need to be booted with an env or something? Seems like graphiti is built to be deployed as either a webserver or an mcp server? |
|
I've tested this successfully! |
Summary
Adds the ability to "forget" things, without having raw access to the data.
Addresses #864
Type of Change
Objective
We don't always want our agents to remember... everything.
Testing
Breaking Changes
Checklist
make lintpasses)Related Issues
Closes #[issue number]