Skip to content

fix: prevent infinite loop in label_propagation when edge_count >= 2#1356

Open
VictorECDSA wants to merge 1 commit intogetzep:mainfrom
VictorECDSA:fix/label-propagation-infinite-loop
Open

fix: prevent infinite loop in label_propagation when edge_count >= 2#1356
VictorECDSA wants to merge 1 commit intogetzep:mainfrom
VictorECDSA:fix/label-propagation-infinite-loop

Conversation

@VictorECDSA
Copy link
Copy Markdown

The original while True loop could oscillate forever when entity pairs have edge_count >= 2. In that case candidate_rank > 1 causes branch A to lower a node's community ID, while the max() fallback in branch B raises it back up in the next iteration, creating a cycle that never satisfies no_change == True.

Fix: replace while True with a bounded for-loop using max_iterations = len(projection) * 10 + 10. The algorithm logic is unchanged -- the loop still breaks early on convergence. The community_map update is moved to before the break check (required by the for-loop structure to preserve the last iteration's result).

Also add tests/utils/maintenance/test_community_operations.py covering termination and correctness for the trigger condition (edge_count >= 2) and several other graph shapes.

Summary

Fix infinite loop in label_propagation() that caused build_communities() to hang indefinitely (100% CPU, no output, no error) when any entity pair in the graph had edge_count >= 2.

Type of Change

  • Bug fix
  • New feature
  • Performance improvement
  • Documentation/Tests

Objective

N/A (bug fix)

Testing

  • Unit tests added/updated (tests/utils/maintenance/test_community_operations.py)
  • Integration tests added/updated
  • All existing tests pass

Without fix — pure Python reproduction (capped at 8 rounds):

round 1: {'A': 1, 'B': 0}
round 2: {'A': 0, 'B': 1}  <- back to initial state!
round 3: {'A': 1, 'B': 0}
...
❌ INFINITE LOOP: still oscillating after 8 rounds

With fix — same trigger graph:

Result clusters: [['A'], ['B']]
✅ Returned without infinite loop
✅ build_communities() returned successfully
✅ 4 community node(s) created in Neo4j

Breaking Changes

  • This PR contains breaking changes

Checklist

  • Code follows project style guidelines (make lint passes)
  • Self-review completed
  • Documentation updated where necessary
  • No secrets or sensitive information committed

Related Issues

Closes #1355

The original while True loop could oscillate forever when entity pairs
have edge_count >= 2. In that case candidate_rank > 1 causes branch A
to lower a node's community ID, while the max() fallback in branch B
raises it back up in the next iteration, creating a cycle that never
satisfies no_change == True.

Fix: replace while True with a bounded for-loop using
max_iterations = len(projection) * 10 + 10. The algorithm logic is
unchanged -- the loop still breaks early on convergence. The
community_map update is moved to before the break check (required by
the for-loop structure to preserve the last iteration's result).

Also add tests/utils/maintenance/test_community_operations.py covering
termination and correctness for the trigger condition (edge_count >= 2)
and several other graph shapes.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@danielchalef
Copy link
Copy Markdown
Member

danielchalef commented Mar 29, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@VictorECDSA
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

danielchalef added a commit that referenced this pull request Mar 29, 2026
2b3pro pushed a commit to 2b3pro/graphiti that referenced this pull request Mar 31, 2026
Port confirmed bug fixes from upstream getzep/graphiti PRs:

- PR getzep#1356: Fix label_propagation infinite loop by updating community_map
  before break check in bounded for-loop
- PR getzep#1362/getzep#1291: Strip markdown code fences from OpenAI generic client
  JSON responses before parsing
- PR getzep#1357: CJK character support in MinHash fuzzy dedup - use Unicode
  \w instead of [a-z0-9], detect CJK for 2-gram shingles vs 3-gram
- PR getzep#1332: Guard against null/invalid embeddings in similarity search
  by adding size() checks to Neo4j and FalkorDB vector queries
- PR getzep#1303: Search both edge directions during dedup resolution using
  bidirectional RELATES_TO match
- PR getzep#1330: Fix FalkorDB default_group_id from escaped '\\_' to '_'

Not applicable (TS port doesn't have the code):
- PR getzep#1281: No Gemini LLM client in TS port
- PR getzep#1276: TS resolver uses client-side scoring, not LLM context
- PR getzep#1289: TS reranker already returns 0 for empty logprobs
- PR getzep#1351: TS episode_mentions_reranker already sorts DESC
- PR getzep#1312: TS already validates node labels
- PR getzep#1212: TS addTripletFull already checks UUID collision
- PRs getzep#1326,1305,1295,1270,1222,1249,1272: FalkorDB RediSearch query
  building not present in TS port (uses Cypher CONTAINS)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ehfazrezwan added a commit to ehfazrezwan/neuralscape that referenced this pull request Apr 2, 2026
feafc42 Bump the uv group across 2 directories with 2 updates (getzep#1363)
c4e6923 Upstream Zep internal improvements (getzep#1361)
e88c09c @VictorECDSA has signed the CLA in getzep#1356
91fe7e0 @majiayu000 has signed the CLA in getzep#1351
c52786d @dudo has signed the CLA in getzep#1350
d631437 @Ker102 has signed the CLA in getzep#1339
73cff2c @chengjon has signed the CLA in getzep#1340
8c61763 @rhlsthrm has signed the CLA in getzep#1335
e6424ba @pratyush618 has signed the CLA in getzep#1332
6f05647 @bsolomon1124 has signed the CLA in getzep#1330
10d9139 @spencer2211 has signed the CLA in getzep#1326
1ca1468 Add hiring promotion section to README (getzep#1323)
19e44a9 Bump mcp-server to 1.0.2 and require graphiti-core>=0.28.2 (getzep#1317)
77b1609 Bump graphiti-core version to 0.28.2 (getzep#1315)
7d65d5e Harden search filters against Cypher injection (getzep#1312)
b10b488 Restore README title and subtitle (getzep#1314)
a9065fa Refresh README content and fix image refs (getzep#1313)
5a334ec @lvca has signed the CLA in getzep#1310
45c8040 @jawherkh has signed the CLA in getzep#1309
9eb2c9e @kraft87 has signed the CLA in getzep#1305
334c8fa @adsharma has signed the CLA in getzep#1296
b6f9d87 @StephenBadger has signed the CLA in getzep#1295
4b91076 feat: Add GLiNER2 hybrid LLM client (getzep#1284)
db54ce0 chore: update Docker images to graphiti-core 0.28.1 (getzep#1292)
edc71e8 @devmao has signed the CLA in getzep#1289
b4ddc55 @carlos-alm has signed the CLA in getzep#1288
aa8e81e @giulio-leone has signed the CLA in getzep#1280
6fdb352 @aelhajj has signed the CLA in getzep#1281
2099603 @avianion has signed the CLA in getzep#1278
9eb59f7 @themavik has signed the CLA in getzep#1214
98f5b5f fix: replace edge name with uuid in debug log (getzep#1261)
510bd50 @hanxiao has signed the CLA in getzep#1257
17a8ea9 @sprotasovitsky has signed the CLA in getzep#1254
9d509a2 @Yifan-233-max has signed the CLA in getzep#1245
ef52a2a chore: regenerate lockfiles to drop diskcache (getzep#1244)
7605303 chore: bump version to 0.28.1 (getzep#1243)
bde2f79 fix: replace diskcache with sqlite-based cache to resolve CVE (getzep#1238)

git-subtree-dir: graphiti
git-subtree-split: feafc42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] label_propagation infinite loop when entity pairs have edge_count >= 2

2 participants