Repository navigation
fix(liveness): Remove the upkeep interval based health check - #852
Merged
Merged
Conversation
This check does not make sense when AlloyDB is the storage, since then the upkeep check is not strictly testing just the one pod. Even with SQLite pools, this check has caused unnecessary restarts during incidents, since a pod that is overloaded can also cause a restart, but that is the opposite of the desired behaviour when the pool is already behind. For now, make this check a no-op. That will help with the current incidents. In the future it can be expanded to do deadlock checks for the different tokio threads.
evanh
force-pushed
the
evanh/fix/remove-health-check
branch
from
November 6, 2026 15:44
3dde594 to
294473a
Compare
evanh
changed the title
lvthanh03
approved these changes
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check does not make sense when AlloyDB is the storage, since then the
upkeep check is not strictly testing just the one pod. Even with SQLite
pools, this check has caused unnecessary restarts during incidents, since
a pod that is overloaded can also cause a restart, but that is the opposite
of the desired behaviour when the pool is already behind.
For now, make this check a no-op. That will help with the current incidents.
In the future it can be expanded to do deadlock checks for the different
tokio threads.