Repository navigation
feat(attributes): return last seen, cardinality, and Relay-modified counts from attribute details endpoint - #130528
Draft
JoshuaKGoldberg wants to merge 4 commits into
Conversation
…ails endpoint Co-Authored-By: Claude <noreply@anthropic.com>
…s by type Co-Authored-By: Claude <noreply@anthropic.com>
…attribute details endpoint Co-Authored-By: Claude <noreply@anthropic.com>
…d number meta keys Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The attribute details endpoint now returns per-dataset stats for the attribute: when it was last seen, its approximate cardinality, and for spans, how many stored values Relay modified (truncated or scrubbed). Each stat is queried independently and comes back null if its query fails, so stats never break the page.
Stats query the attribute's stored names rather than its public key, since one public key can map to several stored names (e.g.
transaction) or to none (proxies likeproject, which get null stats). Last seen comes from Snuba's attribute-names rollup and falls back to a table scan only when the rollup can't answer.Refs EXP-1453, EXP-1456