Repository navigation
ref(redis): Remove routing code left over from rb - #130289
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
strongs
force-pushed
the
strongs/infreng-552-rb-leftovers
branch
from
November 6, 2026 20:50
4f07547 to
37e8ace
Compare
Contributor
Sentry Snapshot Testing
|
strongs
force-pushed
the
strongs/infreng-552-rb-leftovers
branch
from
November 6, 2026 21:30
2901012 to
57067c5
Compare
strongs
marked this pull request as ready for review
November 6, 2026 21:41
Starrao123
approved these changes
Nov 6, 2026
With rb gone, every Redis entry without is_redis_cluster has one host and gets a plain StrictRedis client. Several code paths still existed only to send each key to the right rb host. This removes them. Key names and value formats do not change. The workflow buffer uses its pipelined path for bulk reads and deletes in both modes. Digests, feature adoption, the debounce cache, quotas and the buffer drop client wrappers and arguments that no longer do anything. The lock API drops routing_key, which only RedisBlasterLockBackend read. Refs INFRENG-552 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The test called get_client, which this branch removes from FeatureAdoptionRedisBackend. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
strongs
force-pushed
the
strongs/infreng-552-rb-leftovers
branch
from
November 9, 2026 16:21
57067c5 to
622af22
Compare
The old comment described redis-blaster, which is gone. This test class still covers the str client that a Redis Cluster config gets. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mchen-sentry
added
the
Trigger: getsentry tests
markstory
approved these changes
Nov 9, 2026
wedamija
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With
rbgone, every Redis entry withoutis_redis_clusterhas one host and gets a plainStrictRedisclient. Several code paths still existed only to send each key to the rightrbhost, and now do nothing. This removes them. Key names and value formats do not change.Changes
is_redis_clusterattributeRefs INFRENG-552