Repository navigation
ref(discover): Remove obsolete saved-query dataset splitter - #129853
Merged
Merged
Conversation
Remove the saved-query splitter and exclusive helpers and tests after migration 0894 was deleted. The 25.5.1 hard stop preserves the historical upgrade path; shared dashboard helpers remain.
github-actions
Bot
added
the
Scope: Backend
jamieQ
marked this pull request as ready for review
November 4, 2026 15:00
wmak
approved these changes
Nov 4, 2026
wmak
left a comment
wmak
left a comment
Member
There was a problem hiding this comment.
If you're confident that self-hosted doesn't need this anymore should be safe to burn 🔥
shruthilayaj
approved these changes
Nov 9, 2026
shruthilayaj
left a comment
shruthilayaj
left a comment
Member
There was a problem hiding this comment.
thanks for cleaning this up, it's safe since we'd cut a hard stop migration!
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
_get_and_save_split_decision_for_query, its exclusive helpers, and tests. Added in #76201 (2024-08-29) to classify saved Discover queries as errors or transactions. Its final caller, self-hosted migration0894, was deleted in #92047 (2025-05-21), after the SaaS job was retired in getsentry#17340.Older self-hosted installations must upgrade to 25.5.1 before moving to newer releases. That version includes this function and runs the saved-query migration, so removing the function from current releases preserves the supported upgrade path.