Repository navigation
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
decision-model-linterNot fully checkedFindings may be missing for these files:
decision-model-linter: 7 calls on 1 file, 248,401 input tokens, $0.01, model typesafe/jev-1.13-20260917 |
billyvg
force-pushed
the
billyvg/feat/api-contracts-generated
branch
from
November 3, 2026 20:44
17d1fc8 to
b5413db
Compare
billyvg
force-pushed
the
billyvg/feat/api-contracts-to-typescript
branch
from
November 3, 2026 20:44
4cd9af6 to
1bfb1e5
Compare
Generate static/app/utils/api/apiContracts.generated.ts with `make build-api-contracts`, and list it as a knip entry point so its component types aren't reported as unused exports while call sites adopt them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
billyvg
force-pushed
the
billyvg/feat/api-contracts-generated
branch
from
November 3, 2026 21:05
b5413db to
36eef60
Compare
billyvg
commented
Nov 3, 2026
Comment on lines
+11633
to
+11645
| integrationId: number | null; | ||
| organizationId: number; | ||
| projects: number[]; | ||
| sentryAppId: number | null; | ||
| serviceType: string | null; | ||
| targetDisplay: string | null; | ||
| targetIdentifier: string | null; | ||
| targetType: string | null; | ||
| triggerType: string; | ||
| }; | ||
|
|
||
| /** | ||
| * Allows parameters to be defi |
Member
Author
There was a problem hiding this comment.
I didn't highlight the entire thing but this is repeated in multiple places. how can we get the generator to make sure this is a type alias?
Comment on lines
+16902
to
+16925
| groups: Array<{ | ||
| by: Record<string, unknown>; | ||
| series: Record<string, unknown>; | ||
| totals: Record<string, unknown>; | ||
| }>; | ||
| intervals: string[]; | ||
| start: string; | ||
| }; | ||
|
|
||
| export type OutgoingNotificationAction = { | ||
| id: number; | ||
| integrationId: number | null; | ||
| organizationId: number; | ||
| projects: number[]; | ||
| sentryAppId: number | null; | ||
| serviceType: string | null; | ||
| targetDisplay: string | null; | ||
| targetIdentifier: string | null; | ||
| targetType: string | null; | ||
| triggerType: string; | ||
| }; | ||
|
|
||
| /** | ||
| * Allows parameters to be defi |
Member
Author
There was a problem hiding this comment.
Most of these endpoint types use type aliases, but some of them (like this one), does not. How can we ensure that our generator will always use type aliases?
…feat/api-contracts-generated
Regenerated with `make build-api-contracts` after the generator started naming every ApiMapping response type and declaring repeated enums once. ApiMapping now holds only type names; the 21 responses it spelled out are declared as `<OperationId>Response`, and the 598 timezones, among 53 repeated enums, are declared once, as `TimezoneEnum`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
static/app/utils/api/apiContracts.generated.ts, generated withmake build-api-contractsfrom the PR below. It has 459 component types, and anApiMappingwith response types for 386 methods on 296 routes. Nothing imports it yet; #129593 addsapiOptions.contract(), which reads it.The knip entry keeps the file's component types from being reported as unused exports while call sites adopt them.
It was regenerated with
--validateafter #129568 landed. #129766 regenerates it in CI on backend changes; until that lands, runmake build-api-contractsafter backend response changes.🤖 Generated with Claude Code