Repository navigation
ref(issues): Narrow request.user in issue endpoints - #129419
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 1, 2026 04:24
bbad7ce to
679945d
Compare
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 1, 2026 04:57
679945d to
92a1184
Compare
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 2, 2026 19:55
92a1184 to
20e6610
Compare
Contributor
Sentry Snapshot Testing
|
gricha
force-pushed
the
ref/sa-narrow-issues
branch
2 times, most recently
from
November 2, 2026 20:29
011288f to
ae961a3
Compare
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 2, 2026 20:33
ae961a3 to
4d4ee3f
Compare
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 2, 2026 20:35
4d4ee3f to
c225c3d
Compare
gricha
marked this pull request as ready for review
November 2, 2026 21:02
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 2, 2026 22:08
c225c3d to
d99029a
Compare
gricha
force-pushed
the
ref/sa-narrow-issues
branch
2 times, most recently
from
November 2, 2026 23:08
07c20d1 to
19fadc6
Compare
gricha
force-pushed
the
ref/sa-narrow-issues
branch
4 times, most recently
from
November 3, 2026 00:34
c7cff5b to
dcb6c7f
Compare
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 3, 2026 04:03
dcb6c7f to
f4e7695
Compare
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 3, 2026 04:41
f4e7695 to
a6698d7
Compare
cvxluo
approved these changes
Nov 3, 2026
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 3, 2026 19:53
a6698d7 to
1773603
Compare
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 3, 2026 20:09
1773603 to
f8a2ee9
Compare
Issue endpoints (hashes, similar issues, notes, issue views, supergroups, release commits) read the caller through `sentry.auth.principal`; personal issue-view writes use `require_user()`. - A service account can unmerge (was a 500: `ServiceAccountId` isn't serializable) and gets 404 editing notes it doesn't own; posting a note and saving issue views stay 403 `user-required` by design. Seer no longer receives a service-account id as the user. New tests cover unmerge and notes. - Legacy API keys get 401 instead of a 500 on starred issue views. - Users and agents see no change.
gricha
force-pushed
the
ref/sa-narrow-issues
branch
from
November 3, 2026 20:51
f8a2ee9 to
81112f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue endpoints (hashes, similar issues, notes, issue views, supergroups, release commits) read the caller through
sentry.auth.principal; personal issue-view writes userequire_user().ServiceAccountIdisn't serializable) and gets 404 editing notes it doesn't own; posting a note and saving issue views stay 403user-requiredby design. Seer no longer receives a service-account id as the user. New tests cover unmerge and notes.Left on #129402's mypy allowlist: issue search (
convert_query_values,parse_query,validate_search_filter_permissions). Passing no user there makesassigned:my_teamsresolve to an empty team list, andassigned_to_filter([])matches every issue: an existing bug for users with no teams and API keys, fixed in #129424. Alsoget_create_issue_configingroup_integration_details.py.