feat: re-enable Telemetry Processor and simplify setup#1254
feat: re-enable Telemetry Processor and simplify setup#1254
Conversation
Semver Impact of This PR🟡 Minor (new features) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Internal Changes 🔧Deps
🤖 This preview updates automatically when you update the PR. |
this change pins getsentry/sentry-go#1254, in order to test the Telemetry Processor
ab648d1 to
f12e2cd
Compare
the TestClientReports_Integration was racing with the buffer when the event was added. We should use requireEventually to wait for the event to first be added and then Flush
conditionally having a nil telemetryProcessor creates some conditional issues and is painful to debug. Disabling it when a nil dsn arrives is a tiny optimization that didn't make sense, thus we always should create one when `NewClient` is called.
d0e5d15 to
5229042
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3d172e2. Configure here.
| reportRecorder: report.NoopRecorder(), | ||
| reportProvider: report.NoopProvider(), | ||
| } | ||
| client.setupIntegrations() |
There was a problem hiding this comment.
Moved setupIntegrations before Transport initialization breaks custom integrations
Medium Severity
setupIntegrations() was moved from after transport setup to before it. Custom integrations provided via options.Integrations that access client.Transport in their SetupOnce callback will now get a nil Transport, which was previously always set. This is a behavioral regression since client.Transport is a public field that integrations could reasonably access during setup.
Reviewed by Cursor Bugbot for commit 3d172e2. Configure here.


Description
This PR re-enables support for the Telemetry Processor and includes simplifying it's setup.
Issues
Changelog Entry Instructions
To add a custom changelog entry, uncomment the section above. Supports:
For more details: custom changelog entries
Reminders
feat:,fix:,ref:,meta:)Changelog Entry
DisableTelemetryBufferflag.internal/protocol.Dsnand make it safe to access.