-
-
Notifications
You must be signed in to change notification settings - Fork 389
ci: add SentryCrash import ratchet to PR checks #7723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
itaybre
wants to merge
5
commits into
main
Choose a base branch
from
ci/sentrycrash-import-ratchet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
7dbae14
ci(01-02): add SentryCrash import ratchet script
itaybre 8e08b3e
ci(01-02): wire SentryCrash import ratchet into PR checks
itaybre 27eb999
Fix script to cover imports with whitespaces
itaybre 306592c
Update SentryCrash import check script to focus on specific source diβ¦
itaybre 275b73d
Extract check to a new workflow
itaybre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| #!/bin/bash | ||
|
|
||
| # CI ratchet: ensures SentryCrash import count doesn't increase in SDK sources. | ||
| # Decrease MAX_IMPORTS as phases eliminate imports. Never increase it. | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| # Source CI utilities for proper logging | ||
| SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)" | ||
| # shellcheck source=./ci-utils.sh disable=SC1091 | ||
| source "$SCRIPT_DIR/ci-utils.sh" | ||
|
|
||
| MAX_IMPORTS=59 | ||
|
|
||
| count=$(grep -rn '#import.*SentryCrash' Sources/Sentry Sources/Swift \ | ||
| --include='*.m' --include='*.h' --include='*.c' --include='*.mm' \ | ||
| | grep -vc 'Sources/SentryCrash/' \ | ||
| | tr -d ' ') | ||
itaybre marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
|
|
||
| if [ "$count" -gt "$MAX_IMPORTS" ]; then | ||
| log_error "SentryCrash import count increased from $MAX_IMPORTS to $count" | ||
| log_error "New imports from SDK files into SentryCrash headers are not allowed." | ||
| log_error "Use the SentryCrashReporter protocol instead." | ||
| echo "" | ||
| log_notice "Offending imports:" | ||
| grep -rn '#import.*SentryCrash' Sources/Sentry Sources/Swift \ | ||
| --include='*.m' --include='*.h' --include='*.c' --include='*.mm' \ | ||
| | grep -v 'Sources/SentryCrash/' | ||
| exit 1 | ||
| fi | ||
|
|
||
| log_notice "SentryCrash import ratchet: $count / $MAX_IMPORTS (OK)" | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.