Repository navigation
Conversation
Semver Impact of This PRThis PR lands in these workspaces:
📋 Changelog PreviewThis is how your changes will appear in the changelog. Other Changes
🤖 This preview updates automatically when you update the PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## lcian/feat/rust-automatic-resumable-uploads #746 +/- ##
===============================================================================
+ Coverage 91.79% 91.80% +0.01%
===============================================================================
Files 118 118
Lines 22427 22469 +42
===============================================================================
+ Hits 20586 20628 +42
Misses 1841 1841
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compressed resumable uploads now spool to anonymous temporary files and read each retry at explicit offsets. This avoids leaving named spool files behind after a process crash and lets an earlier HTTP request finish reading without affecting a retry's position.
Stacked on #700. Reads run on Tokio's blocking pool in 4 KiB chunks, using Unix positional reads or Windows
seek_read. Each chunk is zero-initialized and converted toByteswithout copying its contents. Source-path uploads continue opening independent readers.Regression coverage checks overlapping readers, cancellation with a pending read, and premature EOF. Client tests pass with all features and with default features disabled on macOS; the Windows implementation has not been exercised on Windows.