Repository navigation
ref(log): Extract Sentry tracing layer setup into a function - #743
Merged
Merged
Conversation
Move the Sentry layer construction out of the closure in init into a private sentry_layers() function, keeping its imports local to it. List the Sentry filtering in init's docs as grouped bullet points and clarify why only the ErrorLayer filter needs to accept all spans.
Semver Impact of This PR⚪ None (no workspace changed) 📋 Changelog PreviewThis is how your changes will appear in the changelog. This PR does not change any workspace, so it will not appear in any changelog. 🤖 This preview updates automatically when you update the PR. |
lcian
approved these changes
Oct 30, 2026
jan-auer
enabled auto-merge (squash)
October 30, 2026 10:00
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
==========================================
- Coverage 91.56% 91.54% -0.03%
==========================================
Files 116 116
Lines 22084 22088 +4
==========================================
- Hits 20222 20221 -1
- Misses 1862 1867 +5
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #741, which moved
objectstore_log::initto the split Sentry tracing layers. Before this change,initbuilt the layers inside the closure that checks whether the Sentry client is enabled. That closure also held its own imports, soinitwas hard to read.Now a private
sentry_layers()function builds the layers, andinitonly decides whether to attach them. The layers and their filters are the same as before.The
initdocs describe the same filtering as before, as a bullet list grouped by spans and events. The comment on the error filter now names theErrorLayer. It also says why theLogLayerfilter does not need to accept all spans.