Skip to content

feat(log): Capture bigtable_rs PingAndWarm failures as logs #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jan-auer merged 2 commits into from
Oct 27, 2026
Merged

feat(log): Capture bigtable_rs PingAndWarm failures as logs #734

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3184999
feat(log): Capture bigtable_rs PingAndWarm failures as logs
sentry-junior[bot] Oct 23, 2026
43cdcd1
docs(log): Describe default filter intent instead of listing crates
sentry-junior[bot] Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions objectstore-log/src/subscriber.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,10 +78,13 @@ pub fn init(config: &LoggingConfig) {

/// Builds the default [`EnvFilter`] when `RUST_LOG` is not set.
///
/// Uses `INFO` as the base level with `DEBUG` for `tower_http`, then sets `TRACE` for every
/// internal objectstore crate discovered at build time.
/// Uses `INFO` as the base level with `DEBUG` for `tower_http` and `bigtable_rs::bigtable`, then
Comment thread
sentry-junior[bot] marked this conversation as resolved.
Resolved
/// sets `TRACE` for every internal objectstore crate discovered at build time.
///
/// `bigtable_rs::bigtable` logs failed background `PingAndWarm` requests and channel refreshes at
/// `DEBUG`. The module is targeted directly because other `bigtable_rs` modules log per request.
fn default_filter() -> EnvFilter {
let mut filter = EnvFilter::new("INFO,tower_http=DEBUG");
let mut filter = EnvFilter::new("INFO,tower_http=DEBUG,bigtable_rs::bigtable=DEBUG");

for name in CRATE_NAMES {
// INVARIANT: crate names are valid identifiers; the directive cannot fail to parse.
Expand Down
Loading